Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose special name to avoid '@c' by singular's absFactorize #38479

Merged
merged 3 commits into from
Aug 10, 2024

Conversation

nbruin
Copy link
Contributor

@nbruin nbruin commented Aug 6, 2024

Fixes #33327

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@nbruin nbruin changed the title Choose special name to avoid '@c@ by singular's absFactorize Choose special name to avoid '@c' by singular's absFactorize Aug 6, 2024
@dimpase dimpase added the t: bug label Aug 6, 2024
@dimpase
Copy link
Member

dimpase commented Aug 6, 2024

Are you sure "SAGE_ALGEBRAIC" won't pop up somewhere back in Sage data?
Otherwise looks good to me.

@nbruin
Copy link
Contributor Author

nbruin commented Aug 6, 2024

No, it's obviously very doable to create examples that generate a SAGE_ALGEBRAIC identifier name, and introducing the name in the codebase certainly increases the probability of encountering it somewhere. However, the name should not escape from the internal qqbar routine here, so I think it's a definite improvement. If we end up running into examples with this name without people feeling they had it coming, we can write an adaptive name generation routine. The ring gets flattened, so getting an overview of the names involved should be quite doable. Presently I think it would be overengineering to do that.

Copy link

github-actions bot commented Aug 6, 2024

Documentation preview for this PR (built with commit 3b267f8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase
Copy link
Member

dimpase commented Aug 6, 2024

OK, fine.
I tried this kind of workaround, but I forgot an extra pair of ' ' and thought it's trickier than that. :-)

@vbraun vbraun merged commit 8587c13 into sagemath:develop Aug 10, 2024
19 of 21 checks passed
@mkoeppe mkoeppe added this to the sage-10.5 milestone Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

variable name '@c' is not alphanumeric
4 participants