some fixes for ruff code C41 (about loops and iteration) #38323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit ceb9913; changes) is ready! 🎉 |
mkoeppe
reviewed
Jul 1, 2024
mkoeppe
reviewed
Jul 1, 2024
| nontripts = [i for i in nB1 if i not in pts.keys()] | ||
| set_lps = set(lps) | ||
| curvedlines = [list(sx.difference(set_lps)) | ||
| for x in M.flats(2) if (sx := set(x)) not in trilines |
There was a problem hiding this comment.
is this condition ever true? trilines appears to be a list of lists
There was a problem hiding this comment.
This part of the code looked strange before my changes. I am not sure what is intended by the author.
|
merge conflict |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 5, 2024
…tion)
a few minor code fixes in various places, about a better use of loops
https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4
### 📝 Checklist
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
URL: sagemath#38323
Reported by: Frédéric Chapoton
Reviewer(s): Frédéric Chapoton, Matthias Köppe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a few minor code fixes in various places, about a better use of loops
https://docs.astral.sh/ruff/rules/#flake8-comprehensions-c4
📝 Checklist