-
-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added the alt nu-tamari lattices #37221
Conversation
encore une petite erreur à corriger, sans doute en déclarant une dépendance à ton autre ticket dans la description (ici, plus haut dans la page github)
je l'ai trouvée en cherchant |
J'ai ajouté la dernière phrase dans la description, est-ce que c'est bien comme ça qu'il fallait faire ? |
oui, mais peut-etre juste ecrire #37209 ? |
I'm confused on what failed during the Build & Test using Conda ubuntu 3.10. |
l'integration continue est en ce moment pas mal cassée. Les 2 doctests ne sont pas liés à ton code. |
information on the standard Tamari lattice see | ||
:meth:`sage.combinat.tamari_lattices.TamariLattice`, | ||
:meth:`sage.combinat.tamari_lattices.GeneralizedTamariLattice` | ||
:meth:`sage.combinat.tamari_lattices.. GeneralizedTamariLattice` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cette ligne ci-dessus me semble douteuse
- ``p`` -- a `\nu`-Dyck word | ||
|
||
- ``k`` -- an integer between `0` and `p.length()-1` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double back quotes around p.length()-1 (c'est pas du latex)
et idem dans la ligne pour delta
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed. Est-ce que je laisse en simple back quotes autour du 0 ?
Et par rapport à la ligne 12, est-ce qu'il faut aussi modifier la partie \nu-Dyck paths<sage.combinat.nu_dyck_word.NuDyckWord>
pour passer en double back quotes ?
Documentation preview for this PR (built with commit 9fdbfe9; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
feu vert
sagemathgh-37221: Added the alt nu-tamari lattices The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path `\nu` and an integer sequence `\delta`, which is an increment vector with respect to `\nu`. A special choice of `\delta` gives the classical nu-Tamari lattice, and another choice of `\delta` gives the inclusion order on `\nu`-paths---North-East paths weakly above the path `\nu`. These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#37209 URL: sagemath#37221 Reported by: Cchenevi Reviewer(s): Cchenevi, Frédéric Chapoton
sagemathgh-37221: Added the alt nu-tamari lattices The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path `\nu` and an integer sequence `\delta`, which is an increment vector with respect to `\nu`. A special choice of `\delta` gives the classical nu-Tamari lattice, and another choice of `\delta` gives the inclusion order on `\nu`-paths---North-East paths weakly above the path `\nu`. These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies sagemath#37209 URL: sagemath#37221 Reported by: Cchenevi Reviewer(s): Cchenevi, Frédéric Chapoton
The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path
\nu
and an integer sequence\delta
, which is an increment vector with respect to\nu
. A special choice of\delta
gives the classical nu-Tamari lattice, and another choice of\delta
gives the inclusion order on\nu
-paths---North-East paths weakly above the path\nu
.These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case.
📝 Checklist
⌛ Dependencies
#37209