Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the alt nu-tamari lattices #37221

Merged
merged 11 commits into from
Feb 25, 2024
Merged

Conversation

Cchenevi
Copy link

@Cchenevi Cchenevi commented Feb 1, 2024

The alt nu-Tamari lattices are a generalization of the nu-Tamari lattices. These lattices depend on a North-East path \nu and an integer sequence \delta, which is an increment vector with respect to \nu. A special choice of \delta gives the classical nu-Tamari lattice, and another choice of \delta gives the inclusion order on \nu-paths---North-East paths weakly above the path \nu.

These partial orders are implemented in the nu_tamari_lattice module. The special case of the nu-Tamari lattice can be recovered by not precising any vector delta, and benchmark tests suggest that this new method is in fact slightly more efficient than the previous one, even in this case.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation accordingly.

⌛ Dependencies

#37209

@fchapoton
Copy link
Contributor

encore une petite erreur à corriger, sans doute en déclarant une dépendance à ton autre ticket dans la description (ici, plus haut dans la page github)

[sagemath_doc_html-none] OSError: /sage/src/sage/combinat/nu_tamari_lattice.py:docstring of sage.combinat.nu_tamari_lattice:1: WARNING: citation not found: CC2023

je l'ai trouvée en cherchant error dans les logs de build documentation

@Cchenevi
Copy link
Author

Cchenevi commented Feb 3, 2024

encore une petite erreur à corriger, sans doute en déclarant une dépendance à ton autre ticket dans la description (ici, plus haut dans la page github)

[sagemath_doc_html-none] OSError: /sage/src/sage/combinat/nu_tamari_lattice.py:docstring of sage.combinat.nu_tamari_lattice:1: WARNING: citation not found: CC2023

je l'ai trouvée en cherchant error dans les logs de build documentation

J'ai ajouté la dernière phrase dans la description, est-ce que c'est bien comme ça qu'il fallait faire ?

@fchapoton
Copy link
Contributor

oui, mais peut-etre juste ecrire #37209 ?

@fchapoton fchapoton self-assigned this Feb 14, 2024
@Cchenevi
Copy link
Author

I'm confused on what failed during the Build & Test using Conda ubuntu 3.10.

@fchapoton
Copy link
Contributor

l'integration continue est en ce moment pas mal cassée. Les 2 doctests ne sont pas liés à ton code.

information on the standard Tamari lattice see
:meth:`sage.combinat.tamari_lattices.TamariLattice`,
:meth:`sage.combinat.tamari_lattices.GeneralizedTamariLattice`
:meth:`sage.combinat.tamari_lattices.. GeneralizedTamariLattice`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cette ligne ci-dessus me semble douteuse

- ``p`` -- a `\nu`-Dyck word

- ``k`` -- an integer between `0` and `p.length()-1`

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double back quotes around p.length()-1 (c'est pas du latex)

et idem dans la ligne pour delta

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Est-ce que je laisse en simple back quotes autour du 0 ?

Et par rapport à la ligne 12, est-ce qu'il faut aussi modifier la partie \nu-Dyck paths<sage.combinat.nu_dyck_word.NuDyckWord> pour passer en double back quotes ?

Copy link

Documentation preview for this PR (built with commit 9fdbfe9; changes) is ready! 🎉

Copy link
Contributor

@fchapoton fchapoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feu vert

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 18, 2024
sagemathgh-37221: Added the alt nu-tamari lattices
    
The alt nu-Tamari lattices are a generalization of the nu-Tamari
lattices. These lattices depend on a North-East path `\nu` and an
integer sequence `\delta`, which is an increment vector with respect to
`\nu`. A special choice of `\delta` gives the classical nu-Tamari
lattice, and another choice of `\delta` gives the inclusion order on
`\nu`-paths---North-East paths weakly above the path `\nu`.

These partial orders are implemented in the nu_tamari_lattice module.
The special case of the nu-Tamari lattice can be recovered by not
precising any vector delta, and benchmark tests suggest that this new
method is in fact slightly more efficient than the previous one, even in
this case.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

sagemath#37209
    
URL: sagemath#37221
Reported by: Cchenevi
Reviewer(s): Cchenevi, Frédéric Chapoton
vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 19, 2024
sagemathgh-37221: Added the alt nu-tamari lattices
    
The alt nu-Tamari lattices are a generalization of the nu-Tamari
lattices. These lattices depend on a North-East path `\nu` and an
integer sequence `\delta`, which is an increment vector with respect to
`\nu`. A special choice of `\delta` gives the classical nu-Tamari
lattice, and another choice of `\delta` gives the inclusion order on
`\nu`-paths---North-East paths weakly above the path `\nu`.

These partial orders are implemented in the nu_tamari_lattice module.
The special case of the nu-Tamari lattice can be recovered by not
precising any vector delta, and benchmark tests suggest that this new
method is in fact slightly more efficient than the previous one, even in
this case.

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.

### ⌛ Dependencies

sagemath#37209
    
URL: sagemath#37221
Reported by: Cchenevi
Reviewer(s): Cchenevi, Frédéric Chapoton
@vbraun vbraun merged commit 3eac6ea into sagemath:develop Feb 25, 2024
14 of 20 checks passed
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants