Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary bullet point #37215

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

GiacomoPope
Copy link
Contributor

@GiacomoPope GiacomoPope commented Feb 1, 2024

For the installation guide there was an erroneous bullet point which I have removed.

Copy link

github-actions bot commented Feb 1, 2024

Documentation preview for this PR (built with commit a553cc0; changes) is ready! 🎉

@GiacomoPope
Copy link
Contributor Author

GiacomoPope commented Feb 1, 2024

Arguably, one could "refactor" the section so that

Enable Windows Subsystem for Linux (WSL) by following the official WSL setup guide. Be sure to do the steps to install WSL2 and set it as default. Make sure to allocate enough RAM to WSL: 5GB is known to be enough, 2GB might not allow you to build some packages. Then go to the Microsoft Store and install Ubuntu (or another Linux distribution). Start Ubuntu from the start menu.

Is before the "Yes, development" and then have smaller pieces for the remaining info as this is repeated, but this would make the section look unlike the others.

Copy link
Collaborator

@kwankyu kwankyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK.

vbraun pushed a commit to vbraun/sage that referenced this pull request Feb 7, 2024
sagemathgh-37215: Remove unnecessary bullet point
    
For the installation guide there was an erroneous bullet point which I
have removed.
    
URL: sagemath#37215
Reported by: Giacomo Pope
Reviewer(s): Kwankyu Lee
@vbraun vbraun merged commit 23586cf into sagemath:develop Feb 13, 2024
22 of 23 checks passed
@GiacomoPope GiacomoPope deleted the install-guide-formatting branch March 6, 2024 16:25
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants