Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sage-conf optional #37138

Merged
merged 3 commits into from
Apr 27, 2024
Merged

Make sage-conf optional #37138

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f16eb4b
Revert "gh-36964: Add `# sage_setup: distribution` directives to all …
roed314 Apr 13, 2024
5f74854
Make sage-conf optional
tobiasdiez Jan 22, 2024
5bcb9d4
Remove outdated comment
tobiasdiez Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Remove outdated comment
  • Loading branch information
@tobiasdiez
tobiasdiez authored Apr 14, 2024
commit 5bcb9d47707ad9a373ba052fffe0b1c2af0302e2
3 changes: 0 additions & 3 deletions src/pyproject.toml.m4
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
# Minimum requirements for the build system to execute.
requires = [
"sage_setup[autogen]",
# Some version of sage-conf is required.
# Note that PEP517/518 have no notion of optional sage_spkg dependencies:
# https://github.com/pypa/pip/issues/6144
esyscmd(`sage-get-system-packages install-requires-toml \
setuptools \
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line 5 says "Some version of sage-conf is required". But sage_conf is removed from line 9.

Then would pip install sagemath-standard work?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's still working as can be seen from the conda ci workflow.

Thanks for catching the outdated comment. I've removed it now.

wheel \
Expand Down
Loading