some details in infinity "ring" #37137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Jan 23, 2024
| @@ -852,10 +858,10 @@ def _div_(self, other): | |||
| 0 | |||
| """ | |||
| if isinstance(other, UnsignedInfinity): | |||
| return Integer(0) | |||
| return Integer(0) # noqa: F821 | |||
There was a problem hiding this comment.
What does this comment mean?
There was a problem hiding this comment.
this is telling the linter not to warn about Integer being not defined (it is lazy imported).
Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
|
Documentation preview for this PR (built with commit a689fa0; changes) is ready! 🎉 |
tscrim
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
It is totally incomprehensible without an explanation IMO. It suggests to me either we shouldn't use such tools so strictly or we need to tell the tool to ignore something in the tool itself. Its fine in this localized setting for now, but I am sure we will get questions about it later...
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 27, 2024
sagemathgh-37137: some details in infinity "ring" some typing annotations, and using the base class `CommutativeRing` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37137 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 29, 2024
sagemathgh-37137: some details in infinity "ring" some typing annotations, and using the base class `CommutativeRing` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37137 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 30, 2024
sagemathgh-37137: some details in infinity "ring" some typing annotations, and using the base class `CommutativeRing` ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37137 Reported by: Frédéric Chapoton Reviewer(s): Frédéric Chapoton, Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some typing annotations, and using the base class
CommutativeRing📝 Checklist