Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove entirely the legacy class EuclideanDomain #37085

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

fchapoton
Copy link
Contributor

This is getting rid of the deprecated class EuclideanDomain, not used anywhere.

The element class EuclideanDomainElement is kept.

This is one step in cleaning and simplifying the coercion framework.

📝 Checklist

  • The title is concise, informative, and self-explanatory.
  • The description explains in detail what this PR is about.

Copy link

Documentation preview for this PR (built with commit 6c78a66; changes) is ready! 🎉

@pjbruin pjbruin self-requested a review January 18, 2024 13:36
Copy link
Contributor

@pjbruin pjbruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@pjbruin
Copy link
Contributor

pjbruin commented Jan 18, 2024

See also #35286.

@vbraun vbraun merged commit 36b13d7 into sagemath:develop Jan 22, 2024
@fchapoton fchapoton deleted the one_less_legacy_class branch January 22, 2024 08:36
@mkoeppe mkoeppe added this to the sage-10.3 milestone Mar 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants