fix precision issue for π=0 and β=3 in compute_isogeny_stark() #36909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 2a895a3; changes) is ready! π |
yyyyx4
added
s: needs work
s: needs review
and removed
s: needs review
s: needs work
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 22, 2023
sagemathgh-36909: fix precision issue for π=0 and β=3 in compute_isogeny_stark() For the specific case of curves with $j=0$ and isogeny degree $\ell=3$, the `compute_isogeny_stark()` function sometimes fails to find an isogeny even though it exists. In this simple patch we increase the precision of the power-series arithmetic in `compute_isogeny_stark()` by one digit, which makes the computation succeed for this special case too. Fixes sagemath#21883. URL: sagemath#36909 Reported by: Lorenz Panny Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 23, 2023
sagemathgh-36909: fix precision issue for π=0 and β=3 in compute_isogeny_stark() For the specific case of curves with $j=0$ and isogeny degree $\ell=3$, the `compute_isogeny_stark()` function sometimes fails to find an isogeny even though it exists. In this simple patch we increase the precision of the power-series arithmetic in `compute_isogeny_stark()` by one digit, which makes the computation succeed for this special case too. Fixes sagemath#21883. URL: sagemath#36909 Reported by: Lorenz Panny Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 24, 2023
sagemathgh-36909: fix precision issue for π=0 and β=3 in compute_isogeny_stark() For the specific case of curves with $j=0$ and isogeny degree $\ell=3$, the `compute_isogeny_stark()` function sometimes fails to find an isogeny even though it exists. In this simple patch we increase the precision of the power-series arithmetic in `compute_isogeny_stark()` by one digit, which makes the computation succeed for this special case too. Fixes sagemath#21883. URL: sagemath#36909 Reported by: Lorenz Panny Reviewer(s):
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the specific case of curves with$j=0$ and isogeny degree $\ell=3$ , the
compute_isogeny_stark()function sometimes fails to find an isogeny even though it exists. In this simple patch we increase the precision of the power-series arithmetic incompute_isogeny_stark()by one digit, which makes the computation succeed for this special case too.Fixes #21883.