-
-
Notifications
You must be signed in to change notification settings - Fork 645
networkx
3.2.1, igraph
0.10.8, python_igraph
0.11.3
#36750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
On gentoo (https://github.com/sagemath/sage/actions/runs/6961820497/job/18944262177?pr=36750#step:11:6562):
|
This is because python-igraph 0.11.3 requires C/igraph 0.10.8. Gentoo has an outdated version of C/igraph, 0.10.4. |
Thanks for confirming this, that's the lower bound I set in c7c7eb9. Is there an upper bound that I should be setting? |
However, the accurate answer is that each python-igraph release is only guaranteed to be compatible with the same C/igraph that it bundles. If you want bullet-proof, then compile python-igraph with the bundled version of the C core. The reason for the incompatibilities are: (1) newly added functions, as it happened in this case (2) experimental functions that are changed. igraph has "experimental functions" which are excluded from API compatibility guarantees. We reserve the right to change them even across bugfix releases, although we do try to get the design right the first time and avoid such changes. python-igraph does use a few of these experimental functions, so in principle, the current version of python-igraph may become incompatible with a future 0.10.x release of C/igraph. |
Documentation preview for this PR (built with commit 9d9d420; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Fedora 39 and macOS 12.7.1 (M1).
LGTM.
sagemathgh-36750: `networkx` 3.2.1, `igraph` 0.10.8, `python_igraph` 0.11.3 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> - https://networkx.org/documentation/stable/release/release_3.2.html - in particular adds Python 3.12 support - https://networkx.org/documentation/stable/release/release_3.2.1.html - https://igraph.org/news.html <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36750 Reported by: Matthias Köppe Reviewer(s): David Coudert
sagemathgh-36750: `networkx` 3.2.1, `igraph` 0.10.8, `python_igraph` 0.11.3 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> - https://networkx.org/documentation/stable/release/release_3.2.html - in particular adds Python 3.12 support - https://networkx.org/documentation/stable/release/release_3.2.1.html - https://igraph.org/news.html <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36750 Reported by: Matthias Köppe Reviewer(s): David Coudert
sagemathgh-36750: `networkx` 3.2.1, `igraph` 0.10.8, `python_igraph` 0.11.3 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> - https://networkx.org/documentation/stable/release/release_3.2.html - in particular adds Python 3.12 support - https://networkx.org/documentation/stable/release/release_3.2.1.html - https://igraph.org/news.html <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36750 Reported by: Matthias Köppe Reviewer(s): David Coudert
sagemathgh-36750: `networkx` 3.2.1, `igraph` 0.10.8, `python_igraph` 0.11.3 <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes sagemath#1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> - https://networkx.org/documentation/stable/release/release_3.2.html - in particular adds Python 3.12 support - https://networkx.org/documentation/stable/release/release_3.2.1.html - https://igraph.org/news.html <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes sagemath#12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - sagemath#12345: short description why this is a dependency - sagemath#34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: sagemath#36750 Reported by: Matthias Köppe Reviewer(s): David Coudert
📝 Checklist
⌛ Dependencies