Choice of the name of primitive elements for subfields of QQbar #36749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscrim
requested changes
Nov 23, 2023
|
Travis also suggested to remove the final dot in the description of parameters |
Sorry, I read it too quickly. Done. |
tscrim
reviewed
Nov 27, 2023
Correct length hyphen Co-authored-by: Travis Scrimshaw <clfrngrown@aol.com>
tscrim
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Thanks. LGTM.
Whomever thought that a default commit message for some GH way of incorporating reviewer suggested changes should actually work on a project of any meaningful size and then if they cannot see the clear gravity of their error should be immediately fired.
|
Documentation preview for this PR (built with commit b8ec0af; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 10, 2023
sagemathgh-36749: Choice of the name of primitive elements for subfields of QQbar <!-- Describe your changes here in detail --> Added optional keywords `name` for the method `union` and the function `number_field_elements_from_algebraics` from `qqbar.py`. Without this option the name, the name is always `a` and it may conflict if `a` is another object, see https://groups.google.com/g/sage- devel/c/mr9AzpUcbUM ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. URL: sagemath#36749 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Travis Scrimshaw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional keywords
namefor the methodunionand the functionnumber_field_elements_from_algebraicsfromqqbar.py.Without this option the name, the name is always
aand it may conflict ifais another object, see https://groups.google.com/g/sage-devel/c/mr9AzpUcbUM📝 Checklist