Skip to content

Fix sync labels issues for step 2 going live #36213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2023
Merged

Fix sync labels issues for step 2 going live #36213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions .github/sync_labels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ class ReviewDecision(Enum):
"""
changes_requested = 'CHANGES_REQUESTED'
approved = 'APPROVED'
unclear = 'COMMENTED'
unclear = 'UNCLEAR'

class Priority(Enum):
r"""
Expand Down Expand Up @@ -319,12 +319,15 @@ def get_review_decision(self):
return None

if self._review_decision is not None:
if self._review_decision == ReviewDecision.unclear:
return None
return self._review_decision

data = self.view('reviewDecision')
if data:
self._review_decision = ReviewDecision(data)
else:
# To separate a not supplied value from not cached (see https://github.com/sagemath/sage/pull/36177#issuecomment-1704022893 ff)
self._review_decision = ReviewDecision.unclear
info('Review decision for %s: %s' % (self._issue, self._review_decision.value))
return self._review_decision
Expand All @@ -349,9 +352,9 @@ def get_reviews(self, complete=False):
self.get_commits()

date = self._commit_date
no_rev = ReviewDecision.unclear.value
unproper_rev = RevState.commented.value
new_revs = [rev for rev in self._reviews if rev['submittedAt'] > date]
proper_new_revs = [rev for rev in new_revs if rev['state'] != no_rev]
proper_new_revs = [rev for rev in new_revs if rev['state'] != unproper_rev]
info('Proper reviews after %s for %s: %s' % (date, self._issue, proper_new_revs))
return proper_new_revs

Expand Down Expand Up @@ -463,11 +466,6 @@ def approve_allowed(self):
r"""
Return if the actor has permission to approve this PR.
"""
revs = self.get_reviews(complete=True)
if not any(rev['authorAssociation'] in ('MEMBER', 'OWNER') for rev in revs):
info('PR %s can\'t be approved because of missing member review' % (self._issue))
return False

revs = self.get_reviews()
revs = [rev for rev in revs if rev['author']['login'] != self._actor]
ch_req = ReviewDecision.changes_requested
Expand Down