More fixes to support tox 4

[mkoeppe]

The tox.ini files in pkgs/*/ are broken with tox 4.

Early versions of tox 4.x have additional defects.

• Environment variables containing strings with spaces are not accepted any longer for passenv/pass_env. tox-dev/tox#2699 (comment) - factors no longer work in passenv - fixed in tox 4.0.13

• negated factors in deps, like !pipenv-!norequirements: -rrequirements.txt do not work - tox 4 does not support factor all conditionals as 3 tox-dev/tox#2747 - fixed in tox 4.0.15

• And autoprovisioning for downgrade to tox 3 is not working - tox auto-provisioning not working tox-dev/tox#2634

• In SAGE_ROOT/tox.ini, in tox 4 earlier than 4.2.7, numerical factors are broken because they are misinterpreted as Python versions (https://tox.wiki/en/latest/changelog.html#bugfixes-4-2-7); e.g., 4.0.14 is broken:

  tox -e docker-linuxmint-21.1-standard                                                                                                      git:t/34903/tox_ini___gh_actions__update_linux_platforms*
  docker-linuxmint-21.1-standard: skipped because could not find python interpreter with spec(s): 21.1
    docker-linuxmint-21.1-standard: SKIP (1.98 seconds)
  

Here we update affected tox.ini files so that:

• src/tox.ini and pkgs/*/tox.ini work both with suitable versions of tox 3 and tox 4. We change the tox spkg-configure.m4 to check for such versions.
• SAGE_ROOT/tox.ini work with tox >= 4.2.7 (autoprovisioning if necessary)

Follow up:

• Upgrade tox to 4.x #34840 Upgrade tox to 4.x

Depends on #34839

CC: @fchapoton @dimpase

Component: scripts

Author: Matthias Koeppe

Branch/Commit: a2eb816

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/34849

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,4 +1,6 @@
 The tox.ini files in pkgs/*/ are broken with tox 4.
+
+- https://github.com/tox-dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer work in `passenv`
 
 And autoprovisioning for downgrade is not working - https://github.com/tox-dev/tox/issues/2634
 

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,6 +1,6 @@
 The tox.ini files in pkgs/*/ are broken with tox 4.
 
-- https://github.com/tox-dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer work in `passenv`
+- https://github.com/tox-dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer work in `passenv` - fixed in tox 4.0.13
 
 And autoprovisioning for downgrade is not working - https://github.com/tox-dev/tox/issues/2634
 

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,5 +2,7 @@
 
 - https://github.com/tox-dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer work in `passenv` - fixed in tox 4.0.13
 
+- negated factors in `deps`, like `!pipenv-!norequirements: -rrequirements.txt` do not work - https://github.com/tox-dev/tox/issues/2747
+
 And autoprovisioning for downgrade is not working - https://github.com/tox-dev/tox/issues/2634
 

[mkoeppe]

Description changed:

--- 
+++ 
@@ -2,7 +2,7 @@
 
 - https://github.com/tox-dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer work in `passenv` - fixed in tox 4.0.13
 
-- negated factors in `deps`, like `!pipenv-!norequirements: -rrequirements.txt` do not work - https://github.com/tox-dev/tox/issues/2747
+- negated factors in `deps`, like `!pipenv-!norequirements: -rrequirements.txt` do not work - https://github.com/tox-dev/tox/issues/2747 - fixed in tox 4.0.15
 
 And autoprovisioning for downgrade is not working - https://github.com/tox-dev/tox/issues/2634
 

[mkoeppe]

Branch: u/mkoeppe/more_fixes_to_support_tox_4

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

d302a62	tox.ini, src/tox.ini: Adjust to tox 4, autoprovision tox >= 3.18
f8703ae	.github/workflows/lint.yml: Invoke tox with --
9d76204	fix some rst issues in sage_docbuild and sage_setup
4a27a3d	Merge #34839
95fe89a	build/pkgs/tox/spkg-configure.m4: Check for good tox 3, tox 4 versions separately
cc7196a	src/tox.ini: More allowlist_externals for tox 4
1999bd6	src/tox.ini: Quoting fix for tox 4

[sagetrac-git]

Commit: 1999bd6

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

Description changed:

--- 
+++ 
@@ -1,8 +1,15 @@
 The tox.ini files in pkgs/*/ are broken with tox 4.
+
+Early versions of tox 4.0.x have additional defects.
 
 - https://github.com/tox-dev/tox/discussions/2699#discussioncomment-4403536 - factors no longer work in `passenv` - fixed in tox 4.0.13
 
 - negated factors in `deps`, like `!pipenv-!norequirements: -rrequirements.txt` do not work - https://github.com/tox-dev/tox/issues/2747 - fixed in tox 4.0.15
 
-And autoprovisioning for downgrade is not working - https://github.com/tox-dev/tox/issues/2634
+And autoprovisioning for downgrade to tox 3 is not working - https://github.com/tox-dev/tox/issues/2634
 
+Here we update affected `tox.ini` files so that they work both with suitable versions of tox 3 and tox 4. We change the tox `spkg-configure.m4` to check for such versions.
+
+
+Follow up: #34840 Upgrade tox to 4.x
+

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

071c113

Merge tag '9.8.beta6' into t/34849/more_fixes_to_support_tox_4

[sagetrac-git]

Changed commit from 1999bd6 to 071c113

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

70da140	Merge branch 'u/chapoton/support_tox_4' in 9.8.b6
6b8c666	Merge #34839

[sagetrac-git]

Changed commit from 071c113 to 6b8c666

[mkoeppe]

Description changed:

--- 
+++ 
@@ -11,5 +11,13 @@
 Here we update affected `tox.ini` files so that they work both with suitable versions of tox 3 and tox 4. We change the tox `spkg-configure.m4` to check for such versions.
 
 
-Follow up: #34840 Upgrade tox to 4.x
+Follow up: 
+- Also fix numerical factors
 
+  ```
+  tox -e docker-linuxmint-21.1-standard                                                                                                      git:t/34903/tox_ini___gh_actions__update_linux_platforms*
+  docker-linuxmint-21.1-standard: skipped because could not find python interpreter with spec(s): 21.1
+    docker-linuxmint-21.1-standard: SKIP (1.98 seconds)
+  ```
+- #34840 Upgrade tox to 4.x
+

[mkoeppe]

Description changed:

--- 
+++ 
@@ -11,13 +11,15 @@
 Here we update affected `tox.ini` files so that they work both with suitable versions of tox 3 and tox 4. We change the tox `spkg-configure.m4` to check for such versions.
 
 
-Follow up: 
-- Also fix numerical factors
+TODO:
+- Set a lower version bound so that numerical factors work (4.0.14 is broken; 4.2.8 is OK)
 
   ```
   tox -e docker-linuxmint-21.1-standard                                                                                                      git:t/34903/tox_ini___gh_actions__update_linux_platforms*
   docker-linuxmint-21.1-standard: skipped because could not find python interpreter with spec(s): 21.1
     docker-linuxmint-21.1-standard: SKIP (1.98 seconds)
   ```
+
+Follow up: 
 - #34840 Upgrade tox to 4.x