spkg-configure.m4 for gap

[thierry-FreeBSD]

This ticket adds an spkg-configure.m4 for gap, in order to use it from a system package if possible (see #27330).

With this, the installed gap is well detected, but for sagelib and gap packages to built, several paths must be modified:

• GAP_ROOT_DIR in src/sage/env.py

• GAP_ROOT in build/pkgs/gap_packages/spkg-install.in

• gap directory in src/sage/libs/gap/util.pyx

Moreover, the dependency on SAGE_LOCAL needs to be removed. Without it, one currently gets the following error

      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/interfaces/expect.py", line 520, in _start
        raise RuntimeError("unable to start %s: %s" % (self.name(), msg))
    RuntimeError: unable to start gap: End Of File (EOF). Exception style platform.
    Gap finished running /__w/sagetrac-mirror/sagetrac-mirror/.tox/local-sudo-standard/local/bin/gap -r -b -p -T -E -o 401m -s 401m -m 64m /__w/sagetrac-mirror/sagetrac-mirror/src/sage/ext_data/gap/sage.g
    command: /__w/sagetrac-mirror/sagetrac-mirror/.tox/local-sudo-standard/local/bin/gap
    args: ['/__w/sagetrac-mirror/sagetrac-mirror/.tox/local-sudo-standard/local/bin/gap', '-r', '-b', '-p', '-T', '-E', '-o', '401m', '-s', '401m', '-m', '64m', '/__w/sagetrac-mirror/sagetrac-mirror/src/sage/ext_data/gap/sage.g']
    buffer (last 100 chars): b''
    before (last 100 chars): b'Set the environment variable SAGE_LOCAL.\r\n'
    after: <class 'pexpect.exceptions.EOF'>
    match: None
    match_index: None
    exitstatus: 1
    flag_eof: True
    pid: 3124
    child_fd: 26
    closed: False
    timeout: None
    delimiter: <class 'pexpect.exceptions.EOF'>
    logfile: None
    logfile_read: None
    logfile_send: None
    maxread: 4194304
    ignorecase: False
    searchwindowsize: None
    delaybeforesend: None
    delayafterclose: 0.1
    delayafterterminate: 0.1
    searcher: searcher_re:
        0: re.compile(b'gap> ')

CC: @dimpase @orlitzky @slel @isuruf @antonio-rojas

Component: build: configure

Keywords: gap, system packages

Author: Thierry Thomas, Samuel Lelièvre

Branch/Commit: public/29644 @ 2a41f49

Issue created by migration from https://trac.sagemath.org/ticket/29644

[thierry-FreeBSD]

Attachment: spkg-configure.m4.gz

spkg-configure.m4 to be copied under build/pkgs/gap/

[mkoeppe]

comment:1

system package information also needs to be added

[mkoeppe]

Changed author from gh-thierry-FreeBSD to Thierry Thomas

[mkoeppe]

comment:3

Which systems have a usable gap?

[antonio-rojas]

comment:4

I'm using it in the distro sage package with no issues, with the patch from #29314. The only potential problem I'm aware of is that our gap-packages contains all packages shipped in the upstream tarball - this can cause high memory usage if it's installed.

[dimpase]

comment:5

Replying to @antonio-rojas:

I'm using it in the distro sage package with no issues, with the patch from #29314. The only potential problem I'm aware of is that our gap-packages contains all packages shipped in the upstream tarball - this can cause high memory usage if it's installed.

I don't think having all the GAP packages used causes any memory problems - the majority are not loaded by GAP by default (and even if they are, their memory footprint is very small).

[tobiasdiez]

Description changed:

--- 
+++ 
@@ -7,3 +7,38 @@
 - GAP_ROOT in build/pkgs/gap_packages/spkg-install.in
 
 - gap directory in src/sage/libs/gap/util.pyx
+
+
+Moreover, the dependency on SAGE_LOCAL needs to be removed. Without it, one currently gets the following error
+
+```
+      File "/__w/sagetrac-mirror/sagetrac-mirror/src/sage/interfaces/expect.py", line 520, in _start
+        raise RuntimeError("unable to start %s: %s" % (self.name(), msg))
+    RuntimeError: unable to start gap: End Of File (EOF). Exception style platform.
+    Gap finished running /__w/sagetrac-mirror/sagetrac-mirror/.tox/local-sudo-standard/local/bin/gap -r -b -p -T -E -o 401m -s 401m -m 64m /__w/sagetrac-mirror/sagetrac-mirror/src/sage/ext_data/gap/sage.g
+    command: /__w/sagetrac-mirror/sagetrac-mirror/.tox/local-sudo-standard/local/bin/gap
+    args: ['/__w/sagetrac-mirror/sagetrac-mirror/.tox/local-sudo-standard/local/bin/gap', '-r', '-b', '-p', '-T', '-E', '-o', '401m', '-s', '401m', '-m', '64m', '/__w/sagetrac-mirror/sagetrac-mirror/src/sage/ext_data/gap/sage.g']
+    buffer (last 100 chars): b''
+    before (last 100 chars): b'Set the environment variable SAGE_LOCAL.\r\n'
+    after: <class 'pexpect.exceptions.EOF'>
+    match: None
+    match_index: None
+    exitstatus: 1
+    flag_eof: True
+    pid: 3124
+    child_fd: 26
+    closed: False
+    timeout: None
+    delimiter: <class 'pexpect.exceptions.EOF'>
+    logfile: None
+    logfile_read: None
+    logfile_send: None
+    maxread: 4194304
+    ignorecase: False
+    searchwindowsize: None
+    delaybeforesend: None
+    delayafterclose: 0.1
+    delayafterterminate: 0.1
+    searcher: searcher_re:
+        0: re.compile(b'gap> ')
+```

[slel]

comment:7

Thierry, can you push a branch here?
Or would you prefer someone else to commit for you?

The file spkg-configure.m4 you attached can be
committed with you as the author using:

$ git commit --author="Your Name <your.name@example.com>"

with name and email found from your previous contributions using:

$ git log | grep "Author: Thierry Thomas"

[slel]

Changed author from Thierry Thomas to Thierry Thomas, Samuel Lelièvre

[slel]

Commit: 2a41f49