CombinatorialPolyhedron: `bit_repr_` -> `bit_rep_`

[kliem]

This is a follow up on #28608.

It turns out we missed the case bit_repr_.

In order to be consistent, we change this to bit_rep_ (at the moment there are both versions in use).

Even though those 4 python functions in conversions.pyx are very unlikely to be used elsewhere, we add deprecation warnings according to the name those 4 functions had before #28608.

Depends on #29190

CC: @jplab @LaisRast

Component: geometry

Author: Jonathan Kliem

Branch/Commit: 0f38cbe

Reviewer: Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29242

[kliem]

Commit: 2c255ab

[kliem]

Branch: public/29242

[kliem]

New commits:

328c16d	copy for ListOfFaces
8beef7c	add polar for combinatorial polyhedron
2c255ab	_bit_repr_ -> _bit_rep_

[kliem]

comment:2

The reason I missed it is simple: autoreplacement.

When changing back def _repr_(self) I mistakenly also changed bit_rep_ to _bit_repr_ again.

[kliem]

Description changed:

--- 
+++ 
@@ -1,7 +1,7 @@
-This is a follow up on #28616.
+This is a follow up on #28608.
 
 It turns out we missed the case `bit_repr_`.
 
 In order to be consistent, we change this to `bit_rep_` (at the moment there are both versions in use).
 
-Even though those 4 python functions in `conversions.pyx` are very unlikely to be used elsewhere, we add deprecation warnings according to the name those 4 functions had before #28616.
+Even though those 4 python functions in `conversions.pyx` are very unlikely to be used elsewhere, we add deprecation warnings according to the name those 4 functions had before #28608.

[sagetrac-git]

Changed commit from 2c255ab to 1c7f1b2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1c7f1b2

corrected ticket number

[LaisRast]

comment:5

Once #29190 is done, I will put this on "positive review"

[LaisRast]

Reviewer: Laith Rastanawi