Upgrade: Singular 4.2.0, pysingular 0.9.7

[jdemeyer]

Tarball: see checksums.ini on the branch

Use make SAGE_SPKG="sage-spkg -o" singular-clean sagelib-clean build to automatically download and install.

"Critical" because it enables supporting newer versions of FLINT.

We use the Singular development branch (spielwiese) + PR Singular/Singular#1058 in order to build documentation. The tarball is made from https://github.com/mkoeppe/Singular/tree/Release-4-2-0-p1%2Bsage

Upstream: Fixed upstream, but not in a stable release.

CC: @simon-king-jena @timokau @slel @isuruf @saraedum @dkrenn @sagetrac-araichev @cheuberg @behackl @dimpase @videlec

Component: packages: standard

Keywords: upgrade, Singular, pysingular

Author: Antonio Rojas, Markus Wageringel, Matthias Koeppe

Branch: ec471e0

Reviewer: Matthias Koeppe, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/25993

[jdemeyer]

Dependencies: #24735

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1 +1,64 @@
+**Tarball**: http://www.mathematik.uni-kl.de/ftp/pub/Math/Singular/SOURCES/4-1-1/singular-4.1.1p3.tar.gz
 
+This is breaking `p_group_cohomology`:
+
+```
+
+sage -t src/sage/tests/modular_group_cohomology.py
+**********************************************************************
+File "src/sage/tests/modular_group_cohomology.py", line 52, in sage.tests.modular_group_cohomology
+Failed example:
+H.essential_ideal() # optional - p_group_cohomology
+Exception raised:
+Traceback (most recent call last):
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 573, in _run
+self.compile_and_execute(example, compiler, test.globs)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/doctest/forker.py", line 983, in compile_and_execute
+exec(compiled, globs)
+File "<doctest sage.tests.modular_group_cohomology[12]>", line 1, in <module>
+H.essential_ideal() # optional - p_group_cohomology
+File "pGroupCohomology/cohomology.pyx", line 1691, in pGroupCohomology.cohomology.permanent_result.__call__
+File "pGroupCohomology/cohomology.pyx", line 5180, in pGroupCohomology.cohomology.COHO.essential_ideal
+File "pGroupCohomology/cohomology.pyx", line 9760, in pGroupCohomology.cohomology.COHO._lower_bound_depth
+File "pGroupCohomology/cohomology.pyx", line 1691, in pGroupCohomology.cohomology.permanent_result.__call__
+File "pGroupCohomology/cohomology.pyx", line 9826, in pGroupCohomology.cohomology.COHO.depth
+File "pGroupCohomology/cohomology.pyx", line 1691, in pGroupCohomology.cohomology.permanent_result.__call__
+File "pGroupCohomology/cohomology.pyx", line 8041, in pGroupCohomology.cohomology.COHO.filter_regular_parameters
+File "pGroupCohomology/cohomology.pyx", line 1691, in pGroupCohomology.cohomology.permanent_result.__call__
+File "pGroupCohomology/cohomology.pyx", line 8788, in pGroupCohomology.cohomology.COHO.find_small_last_parameter
+File "pGroupCohomology/cohomology.pyx", line 8694, in pGroupCohomology.cohomology.COHO.find_small_last_parameter
+File "pGroupCohomology/cohomology.pyx", line 1691, in pGroupCohomology.cohomology.permanent_result.__call__
+File "pGroupCohomology/cohomology.pyx", line 8380, in pGroupCohomology.cohomology.COHO._get_obvious_parameter
+File "pGroupCohomology/cohomology.pyx", line 6471, in pGroupCohomology.cohomology.COHO.standard_monomials
+File "pGroupCohomology/cohomology.pyx", line 6356, in pGroupCohomology.cohomology.COHO._makeStdMon
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 655, in __call__
+return self._obj.parent().function_call(self._name, [self._obj] + list(args), kwds)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 576, in function_call
+return self.new(s)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/interface.py", line 345, in new
+return self(code)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/singular.py", line 798, in __call__
+return SingularElement(self, type, x, False)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/singular.py", line 1284, in __init__
+raise_(TypeError, TypeError(x), sys.exc_info()[2])
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/singular.py", line 1279, in __init__
+self._name = parent._create(value, type)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/singular.py", line 759, in _create
+self.set(type, name, value)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/singular.py", line 702, in set
+self.eval(cmd)
+File "/usr/local/src/sage-config/local/lib/python2.7/site-packages/sage/interfaces/singular.py", line 660, in eval
+raise SingularError('Singular error:\n%s'%s)
+TypeError: Singular error:
+? ncols(`int`) failed
+? expected ncols(`matrix`)
+? expected ncols(`smatrix`)
+? expected ncols(`ideal`)
+? expected ncols(`module`)
+? expected ncols(`intmat`)
+? expected ncols(`bigintmat`)
+? error occurred in or before STDIN line 5765: ``
+**********************************************************************
+```
+
+(a few more similar error in the same file)

[jdemeyer]

Branch: u/jdemeyer/ticket/25993

[jdemeyer]

Description changed:

--- 
+++ 
@@ -3,7 +3,6 @@
 This is breaking `p_group_cohomology`:
 
 ```
-
 sage -t src/sage/tests/modular_group_cohomology.py
 **********************************************************************
 File "src/sage/tests/modular_group_cohomology.py", line 52, in sage.tests.modular_group_cohomology
@@ -62,3 +61,5 @@
 ```
 
 (a few more similar error in the same file)
+
+It's not clear to me whether this is a Singular bug or a p_group_cohomology bug.

[jdemeyer]

Commit: ec53e6f

[jdemeyer]

Last 10 new commits:

0f55b76	More real -> Float porting
aea0544	Don't check for exact Singular version
4e52b5e	Use p_Divide for lcm as suggested by upstream
50b9ae2	Backport patch to move singular's NTL handling out of libsingular
7b56ef2	Document patch
930ba2e	Remove duplicate cimport
f31d9da	Move patch documentation inside patch itself
07ef11b	rest -> reminder
a9e5aed	Minor fixes to Singular interface
ec53e6f	Upgrade to Singular 4.1.1p3

[simon-king-jena]

comment:5

Sigh. So I have to upgrade the group cohomology package earlier than I thought. I'll see what I can do (after grading some exam).

[simon-king-jena]

comment:6

The ticket description prominently tells that the group cohomology package is failing, but the title of the ticket is about upgrading Singular.

So, just to be sure about the topic of this ticket:

• Is this ticket about upgrading Singular, which means that a new ticket for upgrading the group cohomology package needs to be created? If this is so, which of the tickets should depend on the other?
• Is this ticket only about upgrading the group cohomology package? Looking at the commits, I suppose that this is not the case.

[simon-king-jena]

Replying to @jdemeyer:

It's not clear to me whether this is a Singular bug or a p_group_cohomology bug.

Most likely it is an API change.

[jdemeyer]

comment:8

This ticket is about upgrading Singular. If the p_group_cohomology package must be changed, ideally it should be done in a way which makes it compatible both with Singular 4.1.1p3 as well as earlier versions. In that case, the upgrade of p_group_cohomology can be done on a different ticket and #25993 should depend on that.

Concerning the commit history, only the last commit belongs to this ticket. The rest belongs to #24735 which is an upgrade of Singular to 4.1.1p2.

[simon-king-jena]

comment:9

Replying to @jdemeyer:

Concerning the commit history, only the last commit belongs to this ticket. The rest belongs to #24735 which is an upgrade of Singular to 4.1.1p2.

I see. Do you know if the breakage already happens in p2?