trains() forgets the trains of length one.

[simonbrandhorst]

In sage.modules.genera.genus.canonical_2_adic_trains
forgets the trains of length one.
Maybe this causes further bugs.

Component: quadratic forms

Keywords: sd91

Author: Simon Brandhorst

Branch/Commit: d7fa2c4

Reviewer: David Roe

Issue created by migration from https://trac.sagemath.org/ticket/23955

[simonbrandhorst]

Changed keywords from none to sd91

[simonbrandhorst]

Branch: u/sbrandhorst/trains___forgets_the_trains_of_length_one_

[simonbrandhorst]

New commits:

22c83b7	Rewrote canonical_2_adic_trains()
711bbf0	Removed unnecessary computations of compartments for the train function.

[simonbrandhorst]

Commit: 711bbf0

[roed314]

Changed branch from u/sbrandhorst/trains___forgets_the_trains_of_length_one_ to u/roed/trains___forgets_the_trains_of_length_one_

[roed314]

Reviewer: David Roe

[roed314]

Changed commit from 711bbf0 to 8e8c9cc

[roed314]

comment:5

Most of my changes were superficial, but I did find what I thought was a typo. You used to have

if left_neighbor == 1 or symbol[i] == 1 or right_neighbor==1:

which I changed to

if left_neighbor == 1 or symbol[i][3] == 1 or right_neighbor==1:

based on context. If this is correct, you're happy with the rest of my changes, and tests pass, positive review.

---

New commits:

43cfcc1	Merge branch 'u/sbrandhorst/trains___forgets_the_trains_of_length_one_' of git://trac.sagemath.org/sage into t/23955/trains
8e8c9cc	Small fixes to new trains code

[simonbrandhorst]

comment:6

Thank you for the changes. It is a lot cleaner now.
Tests pass on my machine and the patchbot only complains about long tests in other unrelated components. Seems good.