ehrhart_polynomial should be made available for polytopes defined over QQ

[mkoeppe]

... because they can happen to be lattice polytopes. An exception should be raised when they are not.

See #18812 comment:33

Depends on #28235

CC: @jplab @sophiasage

Component: geometry

Keywords: latte, days100

Author: Sophia Elia

Branch/Commit: b373a3b

Reviewer: Jean-Philippe Labbé, Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/18957

[jplab]

comment:2

This should also be done through the backend normaliz with the version coming after 3.5.3. The call to get the ehrhart_polynomial in normaliz will be facilitated and would be nice to have too.

The upgrade to normaliz 3.5.3 is here: #22984.

[w-bruns]

comment:3

Normaliz and PyNormaliz have the computation goal EhrhartQuasipolynomial since Normaliz version 3.6.0.

[sophiasage]

Branch: public/18957

[sophiasage]

New commits:

49a6107	first step for ehrhart polynomial
d35b4e1	first changes

[sophiasage]

Commit: d35b4e1

[sophiasage]

Changed keywords from latte to latte, days100

[sagetrac-git]

Changed commit from d35b4e1 to c378edb

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

c378edb

more changes

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

50a6441

fixed typos

[sagetrac-git]

Changed commit from c378edb to 50a6441

[sagetrac-git]

Changed commit from 50a6441 to f65b2d9

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

f65b2d9

fixed compactness if statement

[jplab]

comment:9

Let's start with ZZ.

In base_ZZ.py (structure looks great):

• You can correct the doctests later (this might save time)
• ehrhart_polynomial: empty line after INPUT, and period at the end of engine description.
• Eventually replace the third input by the description in the _latte method.
• the current check if self.is_empty(): located at the beginning of _ehrhart_polynomial_latte could be moved to the public ehrhart_polynomial.

In backend_normaliz.py:

• looks good!

• I am tempted to simply make the definition of the two _ehrhart_polynomial_normaliz as alias:

    _ehrhart_polynomial_normaliz = _ehrhart_quasi_polynomial_normaliz

• The check if self.is_empty(): of _ehrhart_quasi_normaliz can be safely removed since the function should not be reached if it is empty since it is dealt with in the front function. I believe the same could also be checked for compactness in the front function (in base_ZZ and base_QQ).

[sagetrac-git]

Changed commit from f65b2d9 to fec936b

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

fec936b

adapt base_ZZ