Don't use TAB characters for indentation

[jdemeyer]

• TABs in Makefiles are needed, so keep them.
• Some TABs not used for indentation are also kept.
• TABs in the obsolete directory devel/sage/sage/server/notebook (Remove old notebook files #11409) are not fixed.
• The directory sage/graphs/planarity_c uses a very inconsistent indentation scheme (mixing spaces and TABs and having varying amounts of indentation) is hopeless to easily fix automatically.
• Also, make indentation consistent and/or remove trailing spaces in some places.

The release manager script has been updated to check all new patches for added TAB indentation.

Apply:

• attachment: 13899_TAB_sage_root.patch to the root repository
• attachment: 13899_TAB_sagelib.patch and attachment: 13899_doctest.patch to the Sage library
• attachment: 13899_TAB_scripts.patch to the scripts repository

Component: misc

Author: Jeroen Demeyer

Reviewer: Leif Leonhardy, Karl-Dieter Crisman

Merged: sage-5.6.beta3

Issue created by migration from https://trac.sagemath.org/ticket/13899

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1 +1,3 @@
+TABs in Makefiles are needed, so keep them.
 
+TABs not used for indentation are also kept.

[jdemeyer]

Description changed:

--- 
+++ 
@@ -1,3 +1,5 @@
-TABs in Makefiles are needed, so keep them.
-
-TABs not used for indentation are also kept.
+* TABs in Makefiles are needed, so keep them.
+* Some TABs not used for indentation are also kept.
+* TABs in the obsolete directory `devel/sage/sage/server/notebook` (#11409) are not fixed.
+* The directory `sage/graphs/planarity_c` uses a very inconsistent indentation scheme (mixing spaces and TABs and having varying amounts of indentation) is hopeless to easily fix automatically.
+* Also, make indentation consistent and/or remove trailing spaces in some places.

[jdemeyer]

Attachment: 13899_TAB_sage_root.patch.gz

[jdemeyer]

Attachment: 13899_TAB_sagelib.patch.gz

[jdemeyer]

Attachment: 13899_TAB_scripts.patch.gz

[jdemeyer]

Description changed:

--- 
+++ 
@@ -3,3 +3,5 @@
 * TABs in the obsolete directory `devel/sage/sage/server/notebook` (#11409) are not fixed.
 * The directory `sage/graphs/planarity_c` uses a very inconsistent indentation scheme (mixing spaces and TABs and having varying amounts of indentation) is hopeless to easily fix automatically.
 * Also, make indentation consistent and/or remove trailing spaces in some places.
+
+The release manager script has been updated to check all new patches for added TAB indentation.

[jdemeyer]

Author: Jeroen Demeyer

[nexttime]

comment:4

Patches look sane (yes, I've read the whole Sage library patch!), haven't tried to apply them yet though.

Other than removing trailing whitespace (and removing useless backslashes at the end of a few lines), I don't see much value in touching the C/C++ and HTML files. In particular, removing tabs that introduce end-of-line comments (in the C/C++ files) is rather counter-productive. [Instead, it would have been worth to translate the French ones, and especially French error messages... ;-) ]

[nexttime]

comment:5

Not sure whether you planned to add further patches here; just noticed it was still "new".

Patches apply to Sage 5.6.beta1, doc builds... (The Sage library patch btw. triggers the rebuild of half of the Sage library.)

Haven't reviewed the merger script though.

[nexttime]

Reviewer: Leif Leonhardy