octahedron() and icosahedron() produce "non-enclosed" polyhedra

[kini]

sage: tetrahedron().edges()
<sage.plot.plot3d.index_face_set.EdgeIter object at 0x6187af0>
sage: cube().edges()
<sage.plot.plot3d.index_face_set.EdgeIter object at 0x618c4b0>
sage: octahedron().edges()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/home/fs/<ipython console> in <module>()

/opt/sage/local/lib/python2.6/site-packages/sage/plot/plot3d/index_face_set.so in sage.plot.plot3d.index_face_set.IndexFaceSet.edges (sage/plot/plot3d/index_face_set.c:5359)()

/opt/sage/local/lib/python2.6/site-packages/sage/plot/plot3d/index_face_set.so in sage.plot.plot3d.index_face_set.EdgeIter.__init__ (sage/plot/plot3d/index_face_set.c:9605)()

TypeError: Must be closed to use the simple iterator.
sage: dodecahedron().edges()
<sage.plot.plot3d.index_face_set.EdgeIter object at 0x6178370>
sage: icosahedron().edges()
---------------------------------------------------------------------------
TypeError                                 Traceback (most recent call last)

/home/fs/<ipython console> in <module>()

/opt/sage/local/lib/python2.6/site-packages/sage/plot/plot3d/index_face_set.so in sage.plot.plot3d.index_face_set.IndexFaceSet.edges (sage/plot/plot3d/index_face_set.c:5359)()

/opt/sage/local/lib/python2.6/site-packages/sage/plot/plot3d/index_face_set.so in sage.plot.plot3d.index_face_set.EdgeIter.__init__ (sage/plot/plot3d/index_face_set.c:9605)()

TypeError: Must be closed to use the simple iterator.

The octahedron and the icosahedron are of course (closed) polyhedra. The problem is, I guess, that the dual() function which creates them is not checking enclosedness and passing it on when generating the dual object.

Marking this ticket as "graphics" since it involves stuff in $SAGE_ROOT/devel/sage/sage/plot/plot3d/.

CC: @kcrisman @mkoeppe @videlec @jplab

Component: graphics

Keywords: platonic octahedron icosahedron enclosed edges

Author: Frédéric Chapoton, Dima Pasechnik

Branch/Commit: e6b73d3

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/11759

[kini]

comment:1

whoops, wrong title

[dimpase]

comment:2

Attachment: trac_11759.patch.gz

I uploaded a trivial patch to fix this issue.

[kini]

comment:3

This should ideally be fixed at the source (i.e. when duals are created). Currently we don't allow the creation of dual objects from non-enclosed IndexFaceSets. This may change in the future (?) since the exception thrown when you try to take the dual of a non-enclosed IndexFaceSet is a NotImplementedError exception. Will this change in the future, or can we just cause the dual() function to always set the object it returns to be an enclosed object? Needs info.