Migrate to meson build system with PPL 1.2 by cxzhong · Pull Request #38 · sagemath/pplpy

cxzhong · 2026-02-07T19:55:22Z

Replace the setuptools/distutils build with Meson:

Add meson.build for the root project, ppl/ package, and tests/
Add pyproject.toml with meson-python backend
Remove setup.py, setup.cfg, and tests/setup*.py

Use Meson wrap to fetch PPL 1.2 source on demand instead of bundling:

Add subprojects/ppl-1.2.wrap downloading from sagemath/sage releases
Add subprojects/packagefiles/ppl-1.2/meson.build as build overlay
Add compiler-fixes patch for C++17 compatibility (std::iterator,
std::auto_ptr, std::mem_fun_ref, memcpy casts, missing includes)
Generate ppl-config.h at configure time without template file
Prefer system PPL via ppl-config script, fall back to subproject

Update CI workflows:

Add wheel builds for ubuntu, macOS ARM, macOS Intel, and linux-arm
Build GMP and GLPK from source for manylinux wheel portability
Add free-threading (cp314t) and musllinux support
Add macOS-15-intel runner to dist.yml matrix
Update pyproject.toml license to GPL-3.0-only
Pin cibuildwheel to v3.3.1, upgrade CI actions to v6
Fixes Use meson-python to build #33

dimpase · 2026-02-08T01:17:02Z

This should not bundle ppl unconditionally. ppl is relatively popular library and is available on many systems.

While ppl does not provide pkg-config configuration, it installs a script called ppl-config, which does things like ppl-config --cxxflags, etc

That is, to get the correct CXXFLAGS (important for C++ compatibility), one can just get them by calling ppl-config --cxxflags. Same for linking (call ppl-config --ldflags)

.github/workflows/dist.yml

cxzhong · 2026-02-08T07:08:19Z

This should not bundle ppl unconditionally. ppl is relatively popular library and is available on many systems.

While ppl does not provide pkg-config configuration, it installs a script called ppl-config, which does things like ppl-config --cxxflags, etc

That is, to get the correct CXXFLAGS (important for C++ compatibility), one can just get them by calling ppl-config --cxxflags. Same for linking (call ppl-config --ldflags)

Since the traditional wheel build also pack ppl and others into wheel.

dimpase · 2026-02-08T07:49:46Z

one does not need to build a dylib from source in order to pack it into a wheel.
pplpy is packaged by Arch, Gentoo, and they certainly will object
to this kind of design

cxzhong · 2026-02-08T07:54:43Z

one does not need to build a dylib from source in order to pack it into a wheel.
pplpy is packaged by Arch, Gentoo, and they certainly will object
to this kind of design

OK, Then I try to find ppl. If do not find then use subproject. but for wheel build. I think it is better to build everything static.

dimpase · 2026-02-08T08:03:58Z

I don't see how it's better. If you have a dylib on your system, you want to reuse it
(ppl also has gmp as a dependency, so it's basically bloating
things up for no reason)

cxzhong · 2026-02-08T08:08:36Z

I don't see how it's better. If you have a dylib on your system, you want to reuse it
(ppl also has gmp as a dependency, so it's basically bloating
things up for no reason)

because it will let user just pip install pplpy, then the user can run this without install some system packages

cxzhong · 2026-02-08T11:47:52Z

Now, if you install libppl-dev and ppl-dev. it can build from system's ppl. If not, it will run a subproject.

dimpase · 2026-02-08T17:14:36Z

I don't see how it's better. If you have a dylib on your system, you want to reuse it
(ppl also has gmp as a dependency, so it's basically bloating
things up for no reason)

because it will let user just pip install pplpy, then the user can run this without install some system packages

there is a number of reasons why it's less preferable: @orlitzky has a good answer I am sure

tobiasdiez · 2026-02-08T17:27:46Z

A good compromise is to try to detect ppl and if not available use it from a subproject. But pls don't include the source files directly, but use a wrap (eg https://github.com/dimpase/primecountpy/blob/master/subprojects/primecount.wrap): https://mesonbuild.com/Wrap-dependency-system-manual.html

orlitzky · 2026-02-08T18:27:42Z

There is a good list at https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies but even that is missing some things like needing to duplicate patches to fix the build with newer compilers, and the ways various licenses change when you are copy/pasting code rather than linking.

And who wants to install pplpy if they don't have PPL first?

dimpase · 2026-02-08T19:12:52Z

A good compromise is to try to detect ppl and if not available use it from a subproject. But pls don't include the source files directly, but use a wrap

yeah, vendoring the sources of ppl is totally unnecessary - I haven't looked at the implementation details yet.

tobiasdiez · 2026-02-08T19:19:54Z

And who wants to install pplpy if they don't have PPL first?

Well, from a user's perspective installing a binary wheel of pplpy that includes PPL is definitively more friendly than having to install PPL first manually, and then building pplpy from source.

subprojects/ppl-1.2/ppl-config.h.mesondefine

subprojects/ppl-1.2/ppl-config.h.in

subprojects/.wraplock

subprojects/packagefiles/ppl-1.2/meson.build

Replace the setuptools/distutils build with Meson: - Add meson.build for the root project, ppl/ package, and tests/ - Add pyproject.toml with meson-python backend - Remove setup.py, setup.cfg, and tests/setup*.py Use Meson wrap to fetch PPL 1.2 source on demand instead of bundling: - Add subprojects/ppl-1.2.wrap downloading from sagemath/sage releases - Add subprojects/packagefiles/ppl-1.2/meson.build as build overlay - Add compiler-fixes patch for C++17 compatibility (std::iterator, std::auto_ptr, std::mem_fun_ref, memcpy casts, missing includes) - Generate ppl-config.h at configure time without template file - Prefer system PPL via ppl-config script, fall back to subproject Update CI workflows: - Add wheel builds for ubuntu, macOS ARM, macOS Intel, and linux-arm - Build GMP and GLPK from source for manylinux wheel portability - Add free-threading (cp314t) and musllinux support - Add macOS-15-intel runner to dist.yml matrix - Update pyproject.toml license to GPL-3.0-only - Pin cibuildwheel to v3.3.1, upgrade CI actions to v6

Removed default C++ standard option from project configuration.

tobiasdiez

Thanks. This looks prettyy good to me. A few smaller suggestions/nit-picks from my side.

ppl/bit_arrays.pyx

ppl/meson.build

subprojects/packagefiles/ppl-1.2/meson.build

meson.build

subprojects/packagefiles/ppl-1.2/meson.build

ppl/congruence.pyx

…nstallation

…pts for improved readability and maintainability

…lity and maintainability

dimpase · 2026-02-11T04:35:41Z

looks mostly good.

Are you sure you need to do things like computing the absolute path to GMP headers?
This looks like an overkill. Pkg-config will tell you if you need any -I to be added to CXXFLAGS

…emove deprecated include/lib directory resolution

ppl/meson.build

tobiasdiez · 2026-02-11T11:51:49Z

subprojects/packagefiles/ppl-1.2/meson.build

+    configure_env += ['LDFLAGS="' + ' '.join(extra_ldflags) + '"']
+endif
+
+# ---------- Build PPL via autotools ----------


Please use https://mesonbuild.com/External-Project-module.html instead of calling configure & make manually. The sagemath repo contains some examples of how to do this as well

ppl package does not provide pc file

I have tested this way, meson can not find ppl

You don't need a pkg config file if you use it that way. The dependency is found via

mylib_dep = p.dependency('mylib') meson.override_dependency('mylib', mylib_dep)

see eg https://github.com/sagemath/sage/blob/5473e598ac601e989b33945622529a827ff9ed0d/subprojects/packagefiles/maxima/meson.build#L35-L43

…uild

…emove environment permissions

dimpase · 2026-02-11T20:37:30Z

pyproject.toml

I don't think you can change the license terms just like this. You need an approval from all significant contributiors - @videlec @vinklein, possibly more

pplpy is distributed under the terms of the GNU General Public License (GPL) published by the Free Software Foundation; either version 3 of the License, or (at your option) any later version. See http://www.gnu.org/licenses/.

It is in the readme. I think it is should be GPL-3.0-or-later not GPL-3.0-only.
I found the mistake today. @dimpase

I don't think you can change the license terms just like this. You need an approval from all significant contributiors - @videlec @vinklein, possibly more

I do not change the license.

I don't know which of the two conflicting entities should take precedence - from readme or here

I don't know which of the two conflicting entities should take precedence - from readme or here

and ppl is distributed by gpl 3.0 or later
https://support.bugseng.com/ppl/
We should follow this

I don't know which of the two conflicting entities should take precedence - from readme or here

And I think before that GPLv3 is not clear license statement.

cxzhong marked this pull request as ready for review February 7, 2026 21:46

cxzhong requested review from dimpase and tobiasdiez February 7, 2026 21:49

dimpase reviewed Feb 8, 2026

View reviewed changes

.github/workflows/dist.yml Show resolved Hide resolved

dimpase reviewed Feb 8, 2026

View reviewed changes

subprojects/ppl-1.2/ppl-config.h.mesondefine Outdated Show resolved Hide resolved

dimpase reviewed Feb 8, 2026

View reviewed changes

subprojects/ppl-1.2/ppl-config.h.in Outdated Show resolved Hide resolved

dimpase reviewed Feb 8, 2026

View reviewed changes

subprojects/.wraplock Outdated Show resolved Hide resolved

dimpase requested changes Feb 8, 2026

View reviewed changes

subprojects/packagefiles/ppl-1.2/meson.build Show resolved Hide resolved

cxzhong force-pushed the meson branch from ba45cc9 to ae3b0ee Compare February 9, 2026 08:56

cxzhong added 2 commits February 9, 2026 17:01

Remove default C++ standard option

8fa69aa

Removed default C++ standard option from project configuration.

Remove default C++17 option from meson.build

158db49

Removed default C++ standard option from project configuration.

cxzhong requested review from dimpase and orlitzky February 9, 2026 09:22

cxzhong changed the title ~~Migrate to meson build system with bundled PPL 1.2~~ Migrate to meson build system with PPL 1.2 Feb 9, 2026

Remove Homebrew pkg-config paths setup from macOS CI workflow

2121e30

cxzhong mentioned this pull request Feb 9, 2026

Release a new version #36

Open

tobiasdiez suggested changes Feb 9, 2026

View reviewed changes

apply the suggestions

f5cfe9f

cxzhong requested a review from vbraun February 9, 2026 14:53

format all meson build files

cde81f7

dimpase reviewed Feb 9, 2026

View reviewed changes

subprojects/packagefiles/ppl-1.2/meson.build Show resolved Hide resolved

dimpase requested changes Feb 9, 2026

View reviewed changes

ppl/congruence.pyx Outdated Show resolved Hide resolved

cxzhong added 10 commits February 10, 2026 11:33

Remove distutils configuration from Cython files

064b4a9

Refactor Meson build to utilize autotools for PPL configuration and i…

29cca06

…nstallation

Add configure-wrapper and pkg-config file for PPL integration

8e7f5f9

Remove configure-wrapper and pkg-config file for PPL integration

c12c185

Add 'ppl' to the environment dependencies

43b74fd

Add wheel repair commands for Linux and macOS in CI workflow

fcf5233

Refactor wheel repair commands for Linux and macOS to use Python scri…

4124c2e

…pts for improved readability and maintainability

Refactor wheel repair commands for Linux and macOS to improve readabi…

bb6a677

…lity and maintainability

format this meson.build

51c6af4

Add meson and meson-python to environment dependencies

4a164d9

cxzhong requested review from dimpase and tobiasdiez February 11, 2026 02:01

Refactor meson.build to streamline GMP and GLPK flag collection and r…

85ddbd9

…emove deprecated include/lib directory resolution

tobiasdiez reviewed Feb 11, 2026

View reviewed changes

ppl/meson.build Outdated Show resolved Hide resolved

tobiasdiez reviewed Feb 11, 2026

View reviewed changes

cxzhong added 5 commits February 11, 2026 21:02

Remove unused common_cpp_args definition from meson.build

2834227

Remove unused cpp_args from extension module configuration in meson.b…

d9efd6d

…uild

Remove cpp_args from Cython extension module configuration in meson.b…

4f0c235

…uild

Update PyPI publish job in dist.yml to use token authentication and r…

f7bd527

…emove environment permissions

Change license from GPL-3.0-only to GPL-3.0-or-later

f5c3293

dimpase requested changes Feb 11, 2026

View reviewed changes

cxzhong requested review from dimpase and tobiasdiez February 15, 2026 10:08

Uh oh!

Comments

Conversation

cxzhong commented Feb 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimpase commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

cxzhong commented Feb 8, 2026

Uh oh!

dimpase commented Feb 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxzhong commented Feb 8, 2026

Uh oh!

dimpase commented Feb 8, 2026

Uh oh!

cxzhong commented Feb 8, 2026

Uh oh!

cxzhong commented Feb 8, 2026

Uh oh!

dimpase commented Feb 8, 2026

Uh oh!

tobiasdiez commented Feb 8, 2026

Uh oh!

orlitzky commented Feb 8, 2026

Uh oh!

dimpase commented Feb 8, 2026

Uh oh!

tobiasdiez commented Feb 8, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

tobiasdiez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dimpase commented Feb 11, 2026

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cxzhong Feb 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

cxzhong commented Feb 7, 2026 •

edited

Loading

dimpase commented Feb 8, 2026 •

edited

Loading

dimpase commented Feb 8, 2026 •

edited

Loading

cxzhong Feb 15, 2026 •

edited

Loading