Update Python version requirements to >= 3.12, include Python 3.13 and 3.14 in CI and wheel building, fix CI#35
Conversation
d4a082f to
c99b4d9
Compare
|
@dimpase wheel building on macos still fails due to an issue with boost (coming from upstream sage, which is used to install a couple of dependencies): It is however installed using homebrew. Any idea how to fix this? |
>= 3.12, include Python 3.13 and 3.14 in CI and wheel building>= 3.12, include Python 3.13 and 3.14 in CI and wheel building, fix CI
…and 3.14 in CI and wheel building
c99b4d9 to
40b3f9f
Compare
|
What " coming from upstream sage" does mean? EDIT - oops, I see what you mean. |
|
let me try this locally |
|
Same issue also on Linux Alpine (boost not found, but installed). |
|
Is the boost check really necessary in the configure script of sage? If boost is not installed, then meson will just disable the one module that actually relies on it. So I would say it would be fine to just print a warning message, and not exit forcefully with an error. |
|
I tried building/testing ( |
|
Why do you even need upstream Sage here? |
|
This package does not depend upon Sage, there is absolutely no need to involve Sage in anything related to building its wheel etc. It's just like |
|
On November 15, 2025 11:47:22 AM EST, Tobias Diez ***@***.***> wrote:
tobiasdiez left a comment (sagemath/pplpy#35)
Is the boost check really necessary in the configure script of sage?
If boost is not installed, then meson will just disable the one module that actually relies on it. So I would say it would be fine to just print a warning message, and not exit forcefully with an error.
There are more spkgs in sage-distro which need boost, so it's better be there.
|
Thanks for testing. I have no idea what then really triggers this issue. Strangely, it also works on macos-15-intel.
Sage-the-distro is used to build gmp, mpfr and mpc, which are needed for building the package/wheel. I would say this PR is then good to go; will try to remove the dependency on sage-the-distro in #34 (using meson's subprojects). |
we don't really test Sage on Alpine. I gather it might be fixed by the following Sage patch (I'll do a PR to add it) --- a/build/pkgs/_prereq/distros/alpine.txt
+++ b/build/pkgs/_prereq/distros/alpine.txt
@@ -23,3 +23,4 @@ bzip2
pkgconf
zlib-dev
boost
+boost-dev |
|
On macOS, the problems must be due to the need for would suffice - but I don't know how to incorporate this. would be better, as it would take care of all the package paths/configs. |
|
I'd try re-factoring the |
|
OK, please use notes I made here in #34 |
|
Thanks for the suggestions. I'll look at them (and your PR to the sage repo, thanks for that!) in a couple of days. Currently it's super busy here. |
sagemathgh-41190: Add boost-dev to Alpine package list in _prereqs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This adds the full boost(dev) on alpine, a platform used to build binary wheels - see e.g. sagemath/pplpy#35 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41190 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
sagemathgh-41190: Add boost-dev to Alpine package list in _prereqs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This adds the full boost(dev) on alpine, a platform used to build binary wheels - see e.g. sagemath/pplpy#35 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41190 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
sagemathgh-41190: Add boost-dev to Alpine package list in _prereqs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This adds the full boost(dev) on alpine, a platform used to build binary wheels - see e.g. sagemath/pplpy#35 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41190 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
sagemathgh-41190: Add boost-dev to Alpine package list in _prereqs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This adds the full boost(dev) on alpine, a platform used to build binary wheels - see e.g. sagemath/pplpy#35 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41190 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
sagemathgh-41190: Add boost-dev to Alpine package list in _prereqs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This adds the full boost(dev) on alpine, a platform used to build binary wheels - see e.g. sagemath/pplpy#35 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41190 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
sagemathgh-41190: Add boost-dev to Alpine package list in _prereqs <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> This adds the full boost(dev) on alpine, a platform used to build binary wheels - see e.g. sagemath/pplpy#35 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#41190 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong
Following https://scientific-python.org/specs/spec-0000/.
Fixes the test CI and wheel building (which are currently broken see eg #34). Also remove a few old/outdated files.