-
-
Notifications
You must be signed in to change notification settings - Fork 29
README.rst, VERSION: Update to 1.11.3 #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
one problem to fix for the release is to make docs build properly. |
|
can we apply #187 first? |
dimpase
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Do you know how to make releases here? |
|
Just create a release tag. If all works well, it will push sdist and wheels to PyPI. (It should have the necessary credentials from the sagemath org...) |
|
there was already the source release on PyPI, not sure why :-) |
|
Should I open a PR to bump cysignals in Sage? |
That part of the workflow ran already when you merged the PR into main. https://github.com/sagemath/cysignals/actions/runs/6409434519/job/17400602464 This shouldn't really happen, it's supposed to happen only when a tag is placed. I'll fix this. The wheels have also been built correctly already in https://github.com/sagemath/cysignals/actions/runs/6409587384, but something went wrong in the upload step. I'll upload the wheels manually for this time and will sent a PR to fix the problem in the workflow. The workflow changes are done in #188, please merge |
Yes please! |
After merging this PR, a release can be tagged. @dimpase @malb