Skip to content

Conversation

@mkoeppe
Copy link

@mkoeppe mkoeppe commented Oct 4, 2023

After merging this PR, a release can be tagged. @dimpase @malb

@dimpase
Copy link
Member

dimpase commented Oct 4, 2023

one problem to fix for the release is to make docs build properly.

@dimpase
Copy link
Member

dimpase commented Oct 4, 2023

can we apply #187 first?

Copy link
Member

@dimpase dimpase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dimpase dimpase merged commit 6c0d008 into sagemath:main Oct 4, 2023
@dimpase
Copy link
Member

dimpase commented Oct 4, 2023

Do you know how to make releases here?

@mkoeppe
Copy link
Author

mkoeppe commented Oct 4, 2023

Just create a release tag. If all works well, it will push sdist and wheels to PyPI. (It should have the necessary credentials from the sagemath org...)

@dimpase
Copy link
Member

dimpase commented Oct 4, 2023

there was already the source release on PyPI, not sure why :-)

@dimpase
Copy link
Member

dimpase commented Oct 4, 2023

Should I open a PR to bump cysignals in Sage?

@mkoeppe
Copy link
Author

mkoeppe commented Oct 4, 2023

there was already the source release on PyPI, not sure why :-)

That part of the workflow ran already when you merged the PR into main. https://github.com/sagemath/cysignals/actions/runs/6409434519/job/17400602464

This shouldn't really happen, it's supposed to happen only when a tag is placed. I'll fix this.

The wheels have also been built correctly already in https://github.com/sagemath/cysignals/actions/runs/6409587384, but something went wrong in the upload step. I'll upload the wheels manually for this time and will sent a PR to fix the problem in the workflow.

The workflow changes are done in #188, please merge

@mkoeppe
Copy link
Author

mkoeppe commented Oct 4, 2023

Should I open a PR to bump cysignals in Sage?

Yes please!

@dimpase
Copy link
Member

dimpase commented Oct 4, 2023

sagemath/sage#36402

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants