Skip to content

Online client integrated #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2018
Merged

Online client integrated #1

merged 1 commit into from
Jun 22, 2018

Conversation

corentinmrnn
Copy link
Collaborator

No description provided.

Callidon
Callidon approved these changes Jun 22, 2018
View reviewed changes
Copy link
Collaborator

@Callidon Callidon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good for me, but with some comments:

  • If possible, install static files (like library) through npm instead of pushing them to the repo
  • There are duplicated <script> import in index_sage.html (bootstrap and jquery are already integrated by the main template)

@Callidon Callidon merged commit 9e552f5 into sage-org:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callidon Callidon Callidon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corentinmrnn @Callidon