Add Additional ERC-4337 Related Passkey Tests #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
nlordell
commented
May 10, 2024
| @@ -175,78 +174,6 @@ describe('Safe4337Module', () => { | |||
| expect(await safeInstance.getOwners()).to.deep.equal([signerAddress]) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('executeUserOp - existing account', () => { | |||
There was a problem hiding this comment.
This test wasn't actually removed, just moved to modules/passkey/test/4337/SafeWebAuthnSigner.spec.ts as it is unrelated to the launchpad and was in the wrong place to begin with.
Conceptually, there are no "executeUserOp - existing account" tests for the launchpad, as it is only ever used for account creation.
Pull Request Test Coverage Report for Build 9062441004Details
💛 - Coveralls |
mmv08
approved these changes
May 13, 2024
nlordell
force-pushed
the
409/additional-tests-and-userstories
branch
from
c0e2a14
to
2b17cd8
Compare
Follow up to #415 Now that we officially tagged the launchpad as "experimental", the module was missing unit and E2E tests demonstrating the "officially" supported way to use passkeys over ERC-4337. This PR adds both a unit test that a user operation with a passkey owner can be executed over the ERC-4337 reference entrypoint, as well as a local bundler test to ensure that no bundler rules are violated by the passkey signers.
nlordell
force-pushed
the
409/additional-4337-tests
branch
from
9e90100
to
5dec2ac
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #415
Now that we officially tagged the launchpad as "experimental", the module was missing unit and E2E tests demonstrating the "officially" supported way to use passkeys over ERC-4337. This PR adds both a unit test that a user operation with a passkey owner can be executed over the ERC-4337 reference entrypoint, as well as a local bundler test to ensure that no bundler rules are violated by the passkey signers.