Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100% Test Coverage for Safe WebAuthn Shared Signer #414

Merged
merged 1 commit into from
May 13, 2024

Conversation

nlordell
Copy link
Collaborator

@nlordell nlordell commented May 6, 2024

Fixes #407

This PR adds unit tests for 100% code coverage for the Safe shared WebAuthn signer contract.

@nlordell nlordell requested a review from a team as a code owner May 6, 2024 20:07
@nlordell nlordell requested review from akshay-ap, mmv08 and remedcu and removed request for a team May 6, 2024 20:07
@nlordell nlordell force-pushed the 407/full-coverage-shared-signer branch from a85650a to 75753a1 Compare May 10, 2024 11:17
@nlordell nlordell force-pushed the 407/full-coverage-shared-signer branch from 75753a1 to 68357e6 Compare May 10, 2024 11:34
@coveralls
Copy link

coveralls commented May 10, 2024

Pull Request Test Coverage Report for Build 9062220863

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.9%) to 87.685%

Totals Coverage Status
Change from base Build 9062159728: 9.9%
Covered Lines: 136
Relevant Lines: 147

💛 - Coveralls

@nlordell nlordell force-pushed the 407/promote-shared-signer branch 3 times, most recently from 9173c38 to 1365f2f Compare May 13, 2024 11:30
Base automatically changed from 407/promote-shared-signer to main May 13, 2024 11:34
@nlordell nlordell force-pushed the 407/full-coverage-shared-signer branch from 68357e6 to 2e73a53 Compare May 13, 2024 11:35
This PR adds unit tests for 100% code coverage for the Safe shared
WebAuthn signer contract.
@nlordell nlordell force-pushed the 407/full-coverage-shared-signer branch from 2e73a53 to 1c7caae Compare May 13, 2024 11:39
@nlordell nlordell merged commit 32b1203 into main May 13, 2024
10 checks passed
@nlordell nlordell deleted the 407/full-coverage-shared-signer branch May 13, 2024 11:48
@github-actions github-actions bot locked and limited conversation to collaborators May 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Singleton Passkey Signer As Officially Supported Scheme
3 participants