Use Account Storage for Shared WebAuthn Signer #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
akshay-ap
reviewed
May 6, 2024
Pull Request Test Coverage Report for Build 9061788035Details
💛 - Coveralls |
nlordell
force-pushed
the
308/single-setup-unit-tests
branch
2 times, most recently
from
89a0cb2
to
8a7eab4
Compare
nlordell
force-pushed
the
408/use-self-storage
branch
from
15a68d1
to
d945f8b
Compare
nlordell
force-pushed
the
408/use-self-storage
branch
from
d945f8b
to
dd263d7
Compare
mmv08
approved these changes
May 13, 2024
This PR reworks the WebAuthn singleton signer to use the account storage instead of its own storage for signer configuration (x, y, and verifiers configuration values). This allows the shared signer to work **without** a staked factory 🎉! We also rename the methods a bit to be more consistent with our signer factory implementation, and adjust the E2E test accordingly (noting that a staked factory is no longer needed).
nlordell
force-pushed
the
408/use-self-storage
branch
from
dd263d7
to
e9eb4cc
Compare
|
I accidentally merged this into the wrong branch 🙈 |
nlordell
added a commit
that referenced
this pull request
May 13, 2024
Fixes #408 This PR reworks the WebAuthn singleton signer to use the account storage instead of its own storage for signer configuration (x, y, and verifiers configuration values). This allows the shared signer to work **without** a staked factory 🎉! We also rename the methods a bit to be more consistent with our signer factory implementation, and adjust the E2E test accordingly (noting that a staked factory is no longer needed). This also required some small adjustments to the `4337-passkeys-singleton-signer` example for the new code (but overall simplification - no need for a staked factory anymore).
nlordell
added a commit
that referenced
this pull request
May 13, 2024
Fixes #408 This PR reworks the WebAuthn singleton signer to use the account storage instead of its own storage for signer configuration (x, y, and verifiers configuration values). This allows the shared signer to work **without** a staked factory 🎉! We also rename the methods a bit to be more consistent with our signer factory implementation, and adjust the E2E test accordingly (noting that a staked factory is no longer needed). This also required some small adjustments to the `4337-passkeys-singleton-signer` example for the new code (but overall simplification - no need for a staked factory anymore).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #408
This PR reworks the WebAuthn singleton signer to use the account storage instead of its own storage for signer configuration (x, y, and verifiers configuration values). This allows the shared signer to work without a staked factory 🎉!
We also rename the methods a bit to be more consistent with our signer factory implementation, and adjust the E2E test accordingly (noting that a staked factory is no longer needed).
This also required some small adjustments to the
4337-passkeys-singleton-signerexample for the new code (but overall simplification - no need for a staked factory anymore).