100% Code Coverage on Signer Launchpad #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlordell
requested review from
akshay-ap,
mmv08 and
remedcu
and removed request for
a team
nlordell
commented
May 10, 2024
| @@ -303,6 +310,7 @@ contract SafeSignerLaunchpad is IAccount, SafeStorage { | |||
| // See <https://docs.soliditylang.org/en/latest/control-structures.html#panic-via-assert-and-error-via-require>. | |||
| mstore(0x00, hex"4e487b71") | |||
| mstore(0x04, 0x21) | |||
| revert(0, 0x24) | |||
There was a problem hiding this comment.
Bug caught by the unit tests.
nlordell
commented
May 10, 2024
| @@ -25,15 +25,15 @@ contract SafeSignerLaunchpad is IAccount, SafeStorage { | |||
| * @notice The EIP-712 type-hash for the domain separator used for verifying Safe initialization signatures. | |||
| * @custom:computed-as keccak256("EIP712Domain(uint256 chainId,address verifyingContract)") | |||
| */ | |||
| bytes32 private constant DOMAIN_SEPARATOR_TYPEHASH = 0x47e79534a245952e8b16893a336b85a3d9ea9fa8c573f3d803afb92a79469218; | |||
| bytes32 private constant _DOMAIN_SEPARATOR_TYPEHASH = 0x47e79534a245952e8b16893a336b85a3d9ea9fa8c573f3d803afb92a79469218; | |||
There was a problem hiding this comment.
Consistent naming.
nlordell
force-pushed
the
308/single-setup
branch
from
772e102
to
1bb7037
Compare
nlordell
force-pushed
the
308/single-setup-unit-tests
branch
from
95cb459
to
89a0cb2
Compare
Pull Request Test Coverage Report for Build 9061845137Details
💛 - Coveralls |
This PR adds 100% code coverage as unit test for the Safe signer launchpad contract.
nlordell
force-pushed
the
308/single-setup-unit-tests
branch
2 times, most recently
from
bec13b0
to
8a7eab4
Compare
mmv08
approved these changes
May 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 100% code coverage as unit test for the Safe signer launchpad contract.
This was introduced as one large PR as I don't see much value in splitting this into individual PRs for review (all changes are related to the introduced unit tests).