Emit signer created event

[akshay-ap]

Fixes #397

Changes in PR:

• Emit signer created event in factory
• Document
• Test

The signer address is not indexed based on the justification below:

Using indexed keyword allows searching for events by filter (useful when searching events using libraries like web3.py, web3.js, etc.), Also, having indexed param would mean that etherum.logs table in Dune would have signer address available in topic1 column. If not marked as indexed, then singer address need to be decoded from data column.

https://docs.soliditylang.org/en/latest/contracts.html#events

Indexing is accompanied by additional gas cost. So, indexed is recommended only if necessary. As we use dune and parsing data column of etherum.logs would give signer address, I don't think indexing is needed.

[nlordell]

Code looks great. Missing reasoning/justification behind why we chose to index no fields.

[nlordell]

Please include in the PR description:

Missing reasoning/justification behind why we chose to index no fields.

[coveralls]

Pull Request Test Coverage Report for Build 8922065551

Details

• 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.07%) to 87.151%

---

Totals
Change from base Build 8920852675:	0.07%
Covered Lines:	122
Relevant Lines:	129

---

💛 - Coveralls