User story: Execute userOp with Passkey and paymaster #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshay-ap
requested review from
nlordell,
mmv08 and
remedcu
and removed request for
a team
akshay-ap
force-pushed
the
feature-276-user-story-paymaster
branch
from
b60675d
to
5d9e53f
Compare
|
I noticed that we had 2 user story directories and that the file naming was inconsistent. I fixed it here: #363 , but this PR does not follow the "standard" either, can you fix it as well? |
nlordell
reviewed
Apr 4, 2024
akshay-ap
force-pushed
the
feature-276-user-story-paymaster
branch
from
34fcef7
to
827b321
Compare
Pull Request Test Coverage Report for Build 8649185035Details
💛 - Coveralls |
remedcu
reviewed
Apr 8, 2024
Co-authored-by: Shebin John <admin@remedcu.com>
Co-authored-by: Shebin John <admin@remedcu.com>
…re-276-user-story-paymaster
mmv08
reviewed
Apr 8, 2024
Co-authored-by: Mikhail <16622558+mmv08@users.noreply.github.com>
nlordell
reviewed
Apr 9, 2024
nlordell
reviewed
Apr 10, 2024
nlordell
reviewed
Apr 10, 2024
Co-authored-by: Nicholas Rodrigues Lordello <nick@safe.global>
Co-authored-by: Nicholas Rodrigues Lordello <nick@safe.global>
akshay-ap
force-pushed
the
feature-276-user-story-paymaster
branch
from
be4ccf5
to
af92a4a
Compare
mmv08
reviewed
Apr 12, 2024
Comment on lines
249
to
252
| const publicKey = decodePublicKey(credential.response) | ||
| await signerFactory.createSigner(publicKey.x, publicKey.y, verifier.target) | ||
| const signer = await signerFactory.getSigner(publicKey.x, publicKey.y, verifier.target) | ||
|
|
There was a problem hiding this comment.
seems like both tests deploy a signer right after the setup, can it be a part of the general setup?
There was a problem hiding this comment.
Agree it might be nice (so the tests assume an existing signer).
nlordell
approved these changes
Apr 12, 2024
|
Approved to reduce back and forth, but agree with #357 (comment) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276
Todo:
Evaluate if
TestPaymastercontract is needed with validation logic. If not needed, replace with aMockContractinstanceChanges in PR: