Fix: remove deprecated client-side tx statuses #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
bh2smith
added a commit
to bh2smith/safe-airdrop
that referenced
this pull request
Sep 23, 2022
[09.2022] Bump Safe Dependencies A few caveats with this update: 1. We had to skip the version bump of @gnosis.pm/safe-react-components from v1.1.5 to v1.2.0 because of this change to their fonts and politely requested that they be put back. 2. Observe that they recently removed two TransactionStatus enums (Fix: remove deprecated client-side tx statuses safe-global/safe-gateway-typescript-sdk#86) so we had to follow suit. 3. There was an awkward built error in our hacky implementation of toWei where number.decimalPlaces() all of a sudden can return null. I wasn't able to tell when this happens, so we simply skip handling it.
app-ravenn7u
added a commit
to app-ravenn7u/safe-airdrop
that referenced
this pull request
Oct 29, 2025
[09.2022] Bump Safe Dependencies A few caveats with this update: 1. We had to skip the version bump of @gnosis.pm/safe-react-components from v1.1.5 to v1.2.0 because of this change to their fonts and politely requested that they be put back. 2. Observe that they recently removed two TransactionStatus enums (Fix: remove deprecated client-side tx statuses safe-global/safe-gateway-typescript-sdk#86) so we had to follow suit. 3. There was an awkward built error in our hacky implementation of toWei where number.decimalPlaces() all of a sudden can return null. I wasn't able to tell when this happens, so we simply skip handling it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These statuses were never returned from the CGW and were client-side only. There's no need for them anymore.