Skip to content

Conversation

@katspaugh
Copy link
Member

A new endpoint for paginated NFTs.

@katspaugh katspaugh requested a review from schmanu July 28, 2022 11:23
Comment on lines +380 to +384
export type SafeIncomingTransfersResponse = Page<IncomingTransfer>

export type SafeModuleTransactionsResponse = Page<ModuleTransaction>

export type SafeMultisigTransactionsResponse = Page<MultisigTransaction>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated, but I moved these tx filter-related types to transactions.ts.

@github-actions
Copy link

github-actions bot commented Jul 28, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Contributor

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 🚀

@katspaugh katspaugh merged commit 6ba54c4 into main Jul 28, 2022
@katspaugh katspaugh deleted the collectibles-v2 branch July 28, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants