Skip to content

Fix: logoUri is not optional in TokenInfo #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 18, 2022
Merged

Fix: logoUri is not optional in TokenInfo #82

merged 1 commit into from
Jul 18, 2022

Conversation

@katspaugh
Copy link
Member

TokenInfo isn't documented, but in the code its logoUri isn't optional.

@katspaugh katspaugh requested a review from DiogoSoaress July 18, 2022 12:19
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

@katspaugh katspaugh requested a review from usame-algan July 18, 2022 12:27
DiogoSoaress
DiogoSoaress approved these changes Jul 18, 2022
View reviewed changes
Copy link
Contributor

@DiogoSoaress DiogoSoaress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@katspaugh katspaugh merged commit fcbf24d into main Jul 18, 2022
@katspaugh katspaugh deleted the logouri branch July 18, 2022 12:28
@katspaugh katspaugh mentioned this pull request Jul 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@usame-algan usame-algan usame-algan approved these changes

@DiogoSoaress DiogoSoaress DiogoSoaress approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@katspaugh @usame-algan @DiogoSoaress