Skip to content

Conversation

@iamacook
Copy link
Contributor

@iamacook iamacook commented May 9, 2022

Overview

This adds new functions/types to call the new, filterable endpoints for incoming, module and multisig transactions.

@github-actions
Copy link

github-actions bot commented May 9, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@iamacook iamacook self-assigned this May 9, 2022
Copy link
Contributor

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work adding those new routes :)

I found some diffs between safe-client-gateway docs and the types here which need some clarification.

address: string
}
query?: {
module?: string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@schmanu schmanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@iamacook iamacook marked this pull request as ready for review May 19, 2022 14:04
@iamacook iamacook merged commit 5b7a487 into main May 19, 2022
@iamacook iamacook deleted the tx-filter-endpoints branch May 19, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants