- 
                Notifications
    You must be signed in to change notification settings 
- Fork 26
feat: add tx filter endpoints #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| ESLint Summary View Full Report
 
 
 Report generated by eslint-plus-action | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work adding those new routes :)
I found some diffs between safe-client-gateway docs and the types here which need some clarification.
| address: string | ||
| } | ||
| query?: { | ||
| module?: string | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the docs: https://safe.global/safe-client-gateway/docs/routes/transactions/filters/module/struct.ModuleFilters.html
There is also a to?: string field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Overview
This adds new functions/types to call the new, filterable endpoints for incoming, module and multisig transactions.