Skip to content

refactor: add SettingsInfo type #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2022
Merged

refactor: add SettingsInfo type #71

merged 2 commits into from
Apr 29, 2022

Conversation

@DiogoSoaress
Copy link
Contributor

Exports the enum SettingsInfoType

@DiogoSoaress DiogoSoaress requested a review from iamacook April 25, 2022 11:23
@github-actions
Copy link

github-actions bot commented Apr 25, 2022 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

iamacook
iamacook approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@DiogoSoaress DiogoSoaress mentioned this pull request Apr 25, 2022
Merged
katspaugh
katspaugh approved these changes Apr 25, 2022
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@DiogoSoaress DiogoSoaress merged commit c06ff3a into main Apr 29, 2022
@DiogoSoaress DiogoSoaress deleted the export-settings-info-type branch April 29, 2022 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katspaugh katspaugh katspaugh approved these changes

+1 more reviewer

@iamacook iamacook iamacook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@DiogoSoaress @katspaugh @iamacook