Skip to content

Conversation

@yagopv
Copy link
Member

@yagopv yagopv commented Mar 2, 2022

What it solves?

Resolves safe-global/safe-apps-sdk#292

How this is solved?

We are adding globalThis prop to the webpack config as the default self in the compiled files is causing problems with SSR solutions as NextJS

@yagopv yagopv requested review from DaniSomoza, dasanra and mmv08 March 2, 2022 12:23
@github-actions
Copy link

github-actions bot commented Mar 2, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@yagopv yagopv merged commit 08c88e1 into main Mar 2, 2022
@yagopv yagopv deleted the feature/use-global-this-instead-self branch March 2, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error trying to instantiate any object: self is not defined

3 participants