Skip to content

Conversation

@yagopv
Copy link
Member

@yagopv yagopv commented Jan 31, 2022

What it solves

Resolves safe-global/safe-apps-sdk#276

How this PR fixes it

As part of the this ticket we are updating the safe-apps-sdk dependencies including the gnosis/safe-react-eslint-plus-action. These changes include a major eslint version bump from 7.x.x to 8.x.x.

The list of affected Gnosis repos will be:

- https://github.com/gnosis/safe-react
- https://github.com/gnosis/safe-react-apps
- https://github.com/gnosis/safe-apps-sdk
- https://github.com/gnosis/safe-react-e2e-tests
- https://github.com/gnosis/safe-react-components
- https://github.com/gnosis/safe-react-gateway-sdk
- https://github.com/gnosis/safe-apps-dev-ui

ESLint 8 bring a lot of changes to the table that can cause issues so as we have several projects using this action we are making PR’s using a concrete tag v3.5.0 for ensuring nothing is affected in the corresponding pipelines.

@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@yagopv yagopv merged commit 221a5d5 into main Feb 1, 2022
@yagopv yagopv deleted the feature/update-eslint-action-dependency branch February 1, 2022 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update safe-apps-sdk dependencies

4 participants