Skip to content

Conversation

@DaniSomoza
Copy link
Contributor

Ticket: safe-global/safe-react-apps#286

With the current SafeAppsResponse type we only accept arrays with 1 item:

Changed

export type SafeAppsResponse = [SafeAppData]

Into

export type SafeAppsResponse = SafeAppData[]

@github-actions
Copy link

github-actions bot commented Jan 17, 2022

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@DaniSomoza DaniSomoza merged commit 3be15fb into main Jan 17, 2022
@DaniSomoza DaniSomoza deleted the bugfix/SafeAppsResponse-type-fix branch January 17, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants