Add types for safe apps access control property and clientUrl param to the query
#51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
katspaugh
reviewed
Jan 6, 2022
src/types/safe-apps.ts
Outdated
| } | ||
|
|
||
| export type SafeAppDomainAllowlistPolicy = { | ||
| type: 'DOMAIN_ALLOWLIST' |
There was a problem hiding this comment.
Might be worth exporting the possible types as an enum, so that in the react app you can branch based on the type?
There was a problem hiding this comment.
This would be my only suggestion as well.
There was a problem hiding this comment.
brainfart sers, thanks for noticing
katspaugh
requested changes
Jan 7, 2022
iamacook
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for 5afe/safe-react#2672. The properties are live on staging config service, the PR to the client gateway is still open.
Ready to merge after 5afe/safe-client-gateway#774