Skip to content

Conversation

@katspaugh
Copy link
Member

Automatically publishing an NPM package w/o 2FA poses a security risk, so we're disabling this.
cc @rmeissner

@github-actions
Copy link

github-actions bot commented Dec 6, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

@@ -30,17 +28,14 @@ jobs:
exit 1
fi
- name: Publish to NPM
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of directly publishing wouldn't make sense to create bundled artifacts to be added to the release in some .zip that could be later on uploaded to npm with all security measures? Instead having to bundle again in local computer without the guarantee of bundling the expected version

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't mind building locally but it could be an option.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me this would minimize other issues like using the wrong commit or forgetting to run npm install before bundling it locally again. I think this is one important value of CI automated systems

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, it could be more robust. Could be a future improvement. Can we merge this PR as is though, for now?
The API key won't work anymore after Richard's changes.

@katspaugh katspaugh merged commit a01ad0b into main Dec 9, 2021
@katspaugh katspaugh deleted the rm-npm branch December 9, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants