Skip to content

Conversation

@iamacook
Copy link
Contributor

To match the new feature in the chains endpoint the FEATURES enum was extended to add SAFE_TX_GAS_OPTIONAL.

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@github-actions
Copy link

github-actions bot commented Nov 29, 2021

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, this feature doesn't belong here. It's not per chain, it's per Safe version.

@iamacook
Copy link
Contributor Author

iamacook commented Nov 29, 2021

Why is this then alongside the same details that are to be returned from the endpoint? No versioning was discussed alongside features. The intention is to remain agnostic as possible.

@iamacook iamacook closed this Nov 29, 2021
@katspaugh katspaugh deleted the add-optional-safe-tx-gas-feature branch November 29, 2021 09:52
@katspaugh katspaugh restored the add-optional-safe-tx-gas-feature branch December 6, 2021 12:48
@katspaugh katspaugh reopened this Dec 6, 2021
@katspaugh
Copy link
Member

Reopened because we still need to define this feature in the enum.

@katspaugh katspaugh merged commit 51fedc8 into main Dec 6, 2021
@katspaugh katspaugh deleted the add-optional-safe-tx-gas-feature branch December 6, 2021 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants