-
Couldn't load subscription status.
- Fork 26
Update chain config types #31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ESLint Summary View Full Report
Report generated by eslint-plus-action |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👏 Some questions regarding the introduction of Feature, Wallet and src/types/networks.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
|
|
||
| export type ChainConfig = { | ||
| chainId: string | ||
| // Remain agnostic as possible and reference what is returned in the CGW, i.e. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❤️
|
For future reference @gnosis/safe-web: I've removed the enums and, although it will feel under-typed in the project, we'll trust whatever comes from the CGW as the single source of truth. Any validations need to reference what is returned from const isValidShortName = (value: string): boolean => (chains.results: ChainInfo[]).some(({ shortName }) => shortName === value)I'm working on migrating |
Additionally, it is possible to get a chain by its A |
The chain config has been updated to include our requested additions of
disabledWallets,featuresandblockExplorerUriTemplate.api. As such, I've recreatedChainInfostruct type.