Skip to content

fix: fallback to statusCode in error message #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025
Merged

fix: fallback to statusCode in error message #213

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions src/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
export type Params = Record<string, string | number | boolean | null>

export type ErrorResponse = {
code: number
message: string
}
export type ErrorResponse =
| {
code: number
statusCode?: never
message: string
}
| {
code?: never
statusCode: number
message: string
}

const isErrorResponse = (data: unknown): data is ErrorResponse => {
const isObject = typeof data === 'object' && data !== null
return isObject && 'code' in data && 'message' in data
return isObject && ('code' in data || 'statusCode' in data) && 'message' in data
}

function replaceParam(str: string, key: string, value: string): string {
Expand Down Expand Up @@ -48,7 +55,7 @@ async function parseResponse<T>(resp: Response): Promise<T> {

if (!resp.ok) {
const errTxt = isErrorResponse(json)
? `CGW error - ${json.code}: ${json.message}`
? `CGW error - ${json.code ?? json.statusCode}: ${json.message}`
: `CGW error - status ${resp.statusText}`
throw new Error(errTxt)
}
Expand Down
Loading