Skip to content

fix: twap executed buy sell amount was incorrect #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix: twap executed buy sell amount was incorrect #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/types/transactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,13 @@ export type SwapTransferOrder = Omit<Transfer, 'type'> &
}

// Specific type for TwapOrder
export type TwapOrder = BaseOrder & {
export type TwapOrder = Omit<BaseOrder, 'executedBuyAmount' | 'executedSellAmount'> & {
type: TransactionInfoType.TWAP_ORDER
/** @description The executed sell token raw amount (no decimals) */
executedSellAmount: null | string
/** @description The executed buy token raw amount (no decimals) */
executedBuyAmount: null | string
/** @description The number of parts the order is split into */
numberOfParts: string
/** @description The amount of sellToken to sell in each part */
partSellAmount: string
Expand Down