Skip to content

refactor the publish job #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2024
Merged

refactor the publish job #181

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a686b1a
refactor: change job name to publish-github
compojoom Jun 25, 2024
76cb27b
refactor: don’t fail if we don’t have to release
compojoom Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ on:
- main

jobs:
publish-npm:
publish-github:
runs-on: ubuntu-latest
steps:
- name: Checkout
Expand All @@ -20,7 +20,9 @@ jobs:
OLD_VERSION=$(git describe --tags --abbrev=0)
NEW_VERSION_NUMBER_ONLY=$(node -p 'require("./package.json").version')
NEW_VERSION=v${NEW_VERSION_NUMBER_ONLY}
if [ $NEW_VERSION != $OLD_VERSION ]; then
echo "OLD_VERSION=$OLD_VERSION" >> $GITHUB_ENV
echo "NEW_VERSION=$NEW_VERSION" >> $GITHUB_ENV
if [ "$NEW_VERSION" != "$OLD_VERSION" ]; then
echo "New version $NEW_VERSION detected"
echo "version=$NEW_VERSION" >> $GITHUB_OUTPUT
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can be removed then, we can use the env var instead.

git log "$OLD_VERSION"..HEAD --pretty=format:"* %s" --invert-grep --grep="$NEW_VERSION_NUMBER_ONLY" > CHANGELOG.md
Expand All @@ -29,20 +31,18 @@ jobs:
fi

- name: Create a git tag
if: steps.version.outputs.version
if: env.NEW_VERSION != env.OLD_VERSION
run: git tag $NEW_VERSION && git push --tags
env:
NEW_VERSION: ${{ steps.version.outputs.version }}

- name: GitHub release
if: steps.version.outputs.version
if: env.NEW_VERSION != env.OLD_VERSION
uses: actions/create-release@v1
id: create_release
with:
draft: false
prerelease: false
release_name: ${{ steps.version.outputs.version }}
tag_name: ${{ steps.version.outputs.version }}
release_name: ${{ env.NEW_VERSION }}
tag_name: ${{ env.NEW_VERSION }}
body_path: CHANGELOG.md
env:
GITHUB_TOKEN: ${{ github.token }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}