feat: Add siwe auth endpoints #177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usame-algan
requested review from
jmealy and
katspaugh
and removed request for
katspaugh
katspaugh
reviewed
Jun 24, 2024
src/index.ts
Outdated
| { | ||
| body, | ||
| }, | ||
| true, |
There was a problem hiding this comment.
It would be good to make the credentials flag part of the endpoint type in api.ts.
katspaugh
approved these changes
Jun 24, 2024
katspaugh
reviewed
Jun 25, 2024
src/index.ts
Outdated
| } | ||
|
|
||
| export function getAuthNonce(): Promise<AuthNonce> { | ||
| return getEndpoint(baseUrl, '/v1/auth/nonce', { credentials: 'include' }, undefined) |
There was a problem hiding this comment.
Do we need to pass undefined explicitly?
Suggested change
| return getEndpoint(baseUrl, '/v1/auth/nonce', { credentials: 'include' }, undefined) | |
| return getEndpoint(baseUrl, '/v1/auth/nonce', { credentials: 'include' }) |
src/types/api.ts
Outdated
| post: operations['verify_auth'] | ||
| parameters: { | ||
| path: null | ||
| credentials: RequestCredentials |
There was a problem hiding this comment.
This can only be include, right? The endpoint doesn't make sense w/ a different value.
Suggested change
| credentials: RequestCredentials | |
| credentials: 'include' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it solves
getAuthNonceandverifyAuthincludeCredentialsparameter to get/post/put/delete callsHow to test
yarn link