Skip to content

fix: Change getRecommendedNonce to getNonces call #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
Merged

fix: Change getRecommendedNonce to getNonces call #140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a464e08
fix: Changes getRecommendedNonces to getNonces call
usame-algan Nov 2, 2023
add6b28
chore: Bump version to v3.13.2
usame-algan Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@safe-global/safe-gateway-typescript-sdk",
"version": "3.13.1",
"version": "3.13.2",
"main": "dist/index.js",
"types": "dist/index.d.ts",
"files": [
Expand Down
6 changes: 3 additions & 3 deletions src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type {
SafeIncomingTransfersResponse,
SafeModuleTransactionsResponse,
SafeMultisigTransactionsResponse,
RecommendedNonceResponse,
NoncesResponse,
} from './types/transactions'
import type {
FiatCurrencies,
Expand Down Expand Up @@ -230,8 +230,8 @@ export function postSafeGasEstimation(
})
}

export function getRecommendedNonce(chainId: string, address: string): Promise<RecommendedNonceResponse> {
return getEndpoint(baseUrl, '/v1/chains/{chainId}/safes/{safe_address}/recommended-nonce', {
export function getNonces(chainId: string, address: string): Promise<NoncesResponse> {
return getEndpoint(baseUrl, '/v1/chains/{chainId}/safes/{safe_address}/nonces', {
path: { chainId, safe_address: address },
})
}
Expand Down
10 changes: 5 additions & 5 deletions src/types/api.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ import type {
SafeIncomingTransfersResponse,
SafeModuleTransactionsResponse,
SafeMultisigTransactionsResponse,
RecommendedNonceResponse,
NoncesResponse,
} from './transactions'
import type { SafeInfo } from './safe-info'
import type { ChainListResponse, ChainInfo } from './chains'
Expand Down Expand Up @@ -305,8 +305,8 @@ export interface paths extends PathRegistry {
}
}
}
'/v1/chains/{chainId}/safes/{safe_address}/recommended-nonce': {
get: operations['get_recommended_nonce']
'/v1/chains/{chainId}/safes/{safe_address}/nonces': {
get: operations['get_nonces']
parameters: {
path: {
chainId: string
Expand Down Expand Up @@ -770,7 +770,7 @@ export interface operations {
}
}
}
get_recommended_nonce: {
get_nonces: {
parameters: {
path: {
chainId: string
Expand All @@ -779,7 +779,7 @@ export interface operations {
}
responses: {
200: {
schema: RecommendedNonceResponse
schema: NoncesResponse
}
}
}
Expand Down
5 changes: 3 additions & 2 deletions src/types/transactions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,8 +406,9 @@ export type SafeTransactionEstimation = {
safeTxGas: string
}

export type RecommendedNonceResponse = {
nonce: number
export type NoncesResponse = {
currentNonce: number
recommendedNonce: number
}

/* Transaction estimation types end */
Expand Down