Skip to content

fix: recommended nonce response #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2023
Merged

fix: recommended nonce response #139

merged 2 commits into from
Oct 30, 2023

Conversation

@usame-algan
Copy link
Contributor

What it solves

Fixes the type introduced in #138 from a number to {nonce: number}

@usame-algan usame-algan requested a review from iamacook October 30, 2023 10:33
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

iamacook
iamacook approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@iamacook iamacook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as per the implementation.

@usame-algan usame-algan merged commit 61800fe into main Oct 30, 2023
@usame-algan usame-algan deleted the fix-rec-nonce-response branch October 30, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@iamacook iamacook iamacook approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@usame-algan @iamacook