Skip to content

Conversation

@katspaugh
Copy link
Member

It's typed as optional in the request type but not in the function signature.

(Introduced in #125.)

Otherwise it breaks safe-wallet-web
@katspaugh katspaugh requested a review from usame-algan August 24, 2023 16:41
@github-actions
Copy link

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total

Report generated by eslint-plus-action

Copy link
Contributor

@usame-algan usame-algan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙌

@katspaugh katspaugh merged commit 2d4d7ee into main Aug 25, 2023
@katspaugh katspaugh deleted the optional-to branch August 25, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants