feat: add notification (un-)registration endpoints #128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ESLint Summary View Full Report
Report generated by eslint-plus-action |
usame-algan
reviewed
Aug 18, 2023
katspaugh
reviewed
Aug 22, 2023
src/types/api.ts
Outdated
| path?: { [key: string]: Primitive } | ||
| } | ||
|
|
||
| interface GetParams extends DeleteParams { |
There was a problem hiding this comment.
This feels a little weird. I would define a common type that both GetParams and DeleteParams extend.
src/types/api.ts
Outdated
|
|
||
| interface PathRegistry { | ||
| [key: string]: GetEndpoint | PostEndpoint | (GetEndpoint & PostEndpoint) | ||
| [key: string]: DeleteEndpoint | GetEndpoint | PostEndpoint | (GetEndpoint & PostEndpoint) |
There was a problem hiding this comment.
Could you add it to the end of the list, not the beginning?
katspaugh
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the device/Safe notification (un-)registration endpoints as per safe-global/safe-client-gateway#636:
/v1/register/notifications/v1/chains/{chainId}/notifications/devices/{uuid}/safes/{safe_address}/v1/chains/{chainId}/notifications/devices/{uuid}