Skip to content

Add humanDescription to TransactionInfo type #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 14, 2023
Merged

Add humanDescription to TransactionInfo type #127

merged 2 commits into from
Aug 14, 2023

Conversation

@usame-algan
Copy link
Contributor

@usame-algan usame-algan commented Aug 14, 2023 •
edited
Loading

Adds the optional humanDescription to TransactionInfo

@usame-algan usame-algan requested a review from katspaugh August 14, 2023 08:46
@github-actions
Copy link

github-actions bot commented Aug 14, 2023 •
edited
Loading

ESLint Summary View Full Report

Annotations are provided inline on the Files Changed tab. You can also see all annotations that were generated on the annotations page.

Type Occurrences Fixable
Errors 0 0
Warnings 0 0
Ignored 0 N/A
  • Result: ✅ success
  • Annotations: 0 total
Report generated by eslint-plus-action

katspaugh
katspaugh approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@katspaugh katspaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like humanDescription better, but this one is OK too.

@usame-algan usame-algan force-pushed the readable-description branch from a8e48b8 to a78a315 Compare August 14, 2023 08:55
@usame-algan usame-algan force-pushed the readable-description branch from a78a315 to 43b63af Compare August 14, 2023 08:56
@usame-algan usame-algan changed the title Add readableDescription to TransactionInfo type Add humanDescription to TransactionInfo type Aug 14, 2023
@usame-algan usame-algan force-pushed the readable-description branch from 0c87a55 to 36c54c5 Compare August 14, 2023 10:55
@usame-algan usame-algan merged commit 32042e3 into main Aug 14, 2023
@usame-algan usame-algan deleted the readable-description branch August 14, 2023 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@katspaugh katspaugh katspaugh approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@usame-algan @katspaugh